From: Nishanth Menon <nm@ti.com>
To: "Javier Martinez Canillas" <javier@osg.samsung.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Alexandru Ardelean" <ardeleanalex@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Jonathan Cameron" <jic23@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when device tree is used
Date: Thu, 30 Jun 2022 22:38:23 -0500 [thread overview]
Message-ID: <20220701033823.gkp5hfowv7f3eemx@tinsel> (raw)
In-Reply-To: <20220630230107.13438-1-nm@ti.com>
On 18:01-20220630, Nishanth Menon wrote:
[...]
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index 622fd384983c..21a7764cbb93 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -181,13 +181,13 @@ static int adc128_probe(struct spi_device *spi)
> }
>
> static const struct of_device_id adc128_of_match[] = {
> - { .compatible = "ti,adc128s052", },
> - { .compatible = "ti,adc122s021", },
> - { .compatible = "ti,adc122s051", },
> - { .compatible = "ti,adc122s101", },
> - { .compatible = "ti,adc124s021", },
> - { .compatible = "ti,adc124s051", },
> - { .compatible = "ti,adc124s101", },
> + { .compatible = "ti,adc128s052", .data = 0},
I should probably cast these as .data = (void *)0 thoughts?
[...]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-07-01 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 23:01 [PATCH] iio: adc: ti-adc128s052: Fix number of channels when device tree is used Nishanth Menon
2022-07-01 3:38 ` Nishanth Menon [this message]
2022-07-01 10:08 ` Andy Shevchenko
2022-07-01 10:13 ` Andy Shevchenko
2022-07-01 16:31 ` Jonathan Cameron
2022-07-05 17:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701033823.gkp5hfowv7f3eemx@tinsel \
--to=nm@ti.com \
--cc=ardeleanalex@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).