Re: [PATCH v3 5/6] power: supply: Add support for mp2733 battery charger

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Saravanan Sekar <sravanhome@gmail.com>
Cc: lee.jones@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, jic23@kernel.org,
	lars@metafoo.de, andy.shevchenko@gmail.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 5/6] power: supply: Add support for mp2733 battery charger
Date: Sun, 11 Sep 2022 15:31:01 +0200	[thread overview]
Message-ID: <20220911133101.7g6hnwp3dnnqrmgb@mercury.elektranox.org> (raw)
In-Reply-To: <20220615145357.2370044-6-sravanhome@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi,

On Wed, Jun 15, 2022 at 04:53:56PM +0200, Saravanan Sekar wrote:
> mp2733 is updated version of mp2629 battery charge management
> which supports USB fast-charge and higher range of input voltage.
> 
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> [...]
>  	psy_cfg.drv_data = charger;
> -	psy_cfg.attr_grp = mp2629_charger_sysfs_groups;
> +	if (charger->chip_info->has_impedance)
> +		psy_cfg.attr_grp = mp2629_charger_sysfs_groups;
> +
> +	if (charger->chip_info->has_fast_charge)
> +		psy_cfg.attr_grp = mp2733_charger_sysfs_groups;
> +
>  	charger->battery = devm_power_supply_register(dev,
>  					 &mp2629_battery_desc, &psy_cfg);
>  	if (IS_ERR(charger->battery)) {

Instead of having has_impedance and has_fast_charge feature
flag that are mutual exclusive, store the device type and
use if/else or switch statement to chose the correct attr_grp.
Other than that:

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]