From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: gupt21@gmail.com, linux-i2c@vger.kernel.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v4 3/5] iio: dac: fix future recursive dependencies
Date: Sat, 24 Sep 2022 17:06:08 +0100 [thread overview]
Message-ID: <20220924170608.3631a9ce@jic23-huawei> (raw)
In-Reply-To: <20220921063026.89619-4-matt.ranostay@konsulko.com>
On Tue, 20 Sep 2022 23:30:24 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> When using 'imply IIO' for other configurations which have 'select GPIOLIB'
> the following recursive dependency is detected for AD5592R/AD5593R
>
> Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per
> recommendation in kconfig-language.rst
>
> drivers/gpio/Kconfig:14:error: recursive dependency detected!
> drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by AD5592R
> drivers/iio/dac/Kconfig:93: symbol AD5592R depends on IIO
> drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221
> drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/dac/Kconfig | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 80521bd28d0f..b93003e80b70 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -92,8 +92,7 @@ config AD5592R_BASE
>
> config AD5592R
> tristate "Analog Devices AD5592R ADC/DAC driver"
> - depends on SPI_MASTER
> - select GPIOLIB
> + depends on SPI_MASTER && GPIOLIB
> select AD5592R_BASE
> help
> Say yes here to build support for Analog Devices AD5592R
> @@ -104,8 +103,7 @@ config AD5592R
>
> config AD5593R
> tristate "Analog Devices AD5593R ADC/DAC driver"
> - depends on I2C
> - select GPIOLIB
> + depends on I2C && GPIOLIB
> select AD5592R_BASE
> help
> Say yes here to build support for Analog Devices AD5593R
next prev parent reply other threads:[~2022-09-24 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 6:30 [PATCH v4 0/5] HID: mcp2221: iio support and device resource management Matt Ranostay
2022-09-21 6:30 ` [PATCH v4 1/5] i2c: muxes: ltc4306: fix future recursive dependencies Matt Ranostay
2022-09-21 6:30 ` [PATCH v4 2/5] iio: addac: stx104: " Matt Ranostay
2022-09-24 16:05 ` Jonathan Cameron
2022-09-21 6:30 ` [PATCH v4 3/5] iio: dac: " Matt Ranostay
2022-09-24 16:06 ` Jonathan Cameron [this message]
2022-09-21 6:30 ` [PATCH v4 4/5] HID: mcp2221: switch i2c registration to devm functions Matt Ranostay
2022-09-21 8:04 ` Benjamin Tissoires
2022-09-21 17:57 ` Matt Ranostay
2022-09-22 23:44 ` Matt Ranostay
2022-09-23 7:03 ` Benjamin Tissoires
2022-09-23 21:22 ` Matt Ranostay
2022-09-24 16:16 ` Jonathan Cameron
2022-09-21 6:30 ` [PATCH v4 5/5] HID: mcp2221: add ADC/DAC support via iio subsystem Matt Ranostay
2022-09-22 10:23 ` kernel test robot
2022-09-24 16:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924170608.3631a9ce@jic23-huawei \
--to=jic23@kernel.org \
--cc=gupt21@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).