From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Tony Lindgren <tony@atomide.com>,
linux-iio@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iio: adc: twl4030-madc: add missing of.h include
Date: Sat, 1 Oct 2022 18:07:05 +0100 [thread overview]
Message-ID: <20221001180705.7002796a@jic23-huawei> (raw)
In-Reply-To: <YzMisM73yj/APB86@smile.fi.intel.com>
On Tue, 27 Sep 2022 19:20:00 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Sep 27, 2022 at 08:46:11AM -0700, Dmitry Torokhov wrote:
> > The driver is using of_device_id/of_match_ptr() and therefore needs
> > to include of.h header. We used to get this definition indirectly via
> > inclusion of matrix_keypad.h from twl.h, but we are cleaning up
> > matrix_keypad.h from unnecessary includes.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a look.
Note that this is 6.2 material now - if that's an issue for the matrix_keypad.h
cleanup then feel free to take it via the input tree with
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
but shout in reply to this so I know to drop it from the iio tree.
Thanks,
Jonathan
>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > v2: adjusted patch description
> >
> > drivers/iio/adc/twl4030-madc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
> > index f8f8aea15612..c279c4f2c9b7 100644
> > --- a/drivers/iio/adc/twl4030-madc.c
> > +++ b/drivers/iio/adc/twl4030-madc.c
> > @@ -30,6 +30,7 @@
> > #include <linux/types.h>
> > #include <linux/gfp.h>
> > #include <linux/err.h>
> > +#include <linux/of.h>
> > #include <linux/regulator/consumer.h>
> >
> > #include <linux/iio/iio.h>
> > --
> > 2.38.0.rc1.362.ged0d419d3c-goog
> >
>
next prev parent reply other threads:[~2022-10-01 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 15:46 [PATCH v2 1/3] watchdog: twl4030_wdt: add missing mod_devicetable.h include Dmitry Torokhov
2022-09-27 15:46 ` [PATCH v2 2/3] mfd: twl4030-irq: add missing device.h include Dmitry Torokhov
2022-09-28 15:14 ` Lee Jones
2022-09-27 15:46 ` [PATCH v2 3/3] iio: adc: twl4030-madc: add missing of.h include Dmitry Torokhov
2022-09-27 16:20 ` Andy Shevchenko
2022-10-01 17:07 ` Jonathan Cameron [this message]
2022-10-01 22:14 ` Dmitry Torokhov
2022-10-02 12:57 ` Jonathan Cameron
2022-10-28 5:09 ` Dmitry Torokhov
2022-09-27 16:20 ` Andy Shevchenko
2022-09-28 1:11 ` [PATCH v2 1/3] watchdog: twl4030_wdt: add missing mod_devicetable.h include Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221001180705.7002796a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tony@atomide.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).