From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wei Yongjun <weiyongjun@huaweicloud.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/5 v3] iio: Silence no spi_device_id warnings
Date: Sun, 2 Oct 2022 15:03:41 +0100 [thread overview]
Message-ID: <20221002150341.48b071dc@jic23-huawei> (raw)
In-Reply-To: <CAHp75VfaWS0H6F0LmnmW9SS0JZNwfXRzFoCTP5FOfzMP_CUNLA@mail.gmail.com>
On Wed, 21 Sep 2022 23:41:54 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Wed, Sep 21, 2022 at 7:19 PM Wei Yongjun <weiyongjun@huaweicloud.com> wrote:
> >
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > SPI devices use the spi_device_id for module autoloading even on
> > systems using device tree.
> >
> > Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
> > compatible") added a test to check that every SPI driver has a
> > spi_device_id for each DT compatiable string defined by driver
> > and warns if the spi_device_id is missing.
> >
> > This series add spi_device_id entries to silence the warnings, and
> > ensure driver module autoloading works.
>
> Nice, but I would like to avoid the unneeded churn in the future and
> right away use a new API for that. I will submit a patch soon that you
> may attach to your series as a prerequisite.
>
Given Andy's suggestion (which I like, but no one else has replied to!)
isn't moving forwards particularly quickly.... I've applied this series
as it stands. We will just have to cope with the churn (there will be
a lot beyond these few drivers anyway to fully take advantage of
the utility function Andy has suggested)
Applied to the togreg branch of iio.git as 6.2 material. I'll push out
as testing for now for 0-day to see if it can find any problems. Will be
rebasing that tree on rc1.
Jonathan
next prev parent reply other threads:[~2022-10-02 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 16:36 [PATCH 0/5 v3] iio: Silence no spi_device_id warnings Wei Yongjun
2022-09-21 16:36 ` [PATCH 1/5 v3] iio: adc: ti-ads131e08: " Wei Yongjun
2022-09-22 5:43 ` Uwe Kleine-König
2022-09-22 11:13 ` Jonathan Cameron
2022-09-22 13:26 ` Andy Shevchenko
2022-09-21 16:36 ` [PATCH 2/5 v3] iio: accel: sca3300: Silence no spi_device_id warning Wei Yongjun
2022-09-22 6:12 ` Tomas Melin
2022-09-21 16:36 ` [PATCH 3/5 v3] iio: adc: ad9467: Silence no spi_device_id warnings Wei Yongjun
2022-09-21 16:36 ` [PATCH 4/5 v3] iio: adc: ad7192: " Wei Yongjun
2022-09-21 16:36 ` [PATCH 5/5 v3] iio: adc: ad7124: " Wei Yongjun
2022-09-21 20:41 ` [PATCH 0/5 v3] iio: " Andy Shevchenko
2022-10-02 14:03 ` Jonathan Cameron [this message]
2022-10-03 7:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002150341.48b071dc@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=weiyongjun@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).