From: Jonathan Cameron <jic23@kernel.org>
To: Philipp Jungkamp <p.jungkamp@gmx.net>
Cc: Todd Brandt <todd.e.brandt@intel.com>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, todd.e.brandt@linux.intel.com,
srinivas.pandruvada@linux.intel.com, jikos@kernel.org
Subject: Re: [PATCH] Fix buffer overrun in HID-SENSOR name.
Date: Sat, 11 Mar 2023 12:31:48 +0000 [thread overview]
Message-ID: <20230311123148.0fbe1091@jic23-huawei> (raw)
In-Reply-To: <b9dab02783e5eeaa74b291d4394150689e7c7b8a.camel@gmx.net>
On Sat, 11 Mar 2023 01:53:22 +0100
Philipp Jungkamp <p.jungkamp@gmx.net> wrote:
> This is exactly the fix I proposed. Thank you for testing and properly
> submitting it.
>
> Regards,
> Philipp Jungkamp
Looks good to me as well.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> On Fri, 2023-03-10 at 15:54 -0800, Todd Brandt wrote:
> > Philipp Jungkamp created this fix, I'm simply submitting it. I've
> > verified it fixes bugzilla issue 217169.
> >
> > Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217169
> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
> > ---
> > drivers/hid/hid-sensor-custom.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > sensor-custom.c
> > index 3e3f89e01d81..d85398721659 100644
> > --- a/drivers/hid/hid-sensor-custom.c
> > +++ b/drivers/hid/hid-sensor-custom.c
> > @@ -940,7 +940,7 @@ hid_sensor_register_platform_device(struct
> > platform_device *pdev,
> > struct hid_sensor_hub_device
> > *hsdev,
> > const struct
> > hid_sensor_custom_match *match)
> > {
> > - char real_usage[HID_SENSOR_USAGE_LENGTH];
> > + char real_usage[HID_SENSOR_USAGE_LENGTH] = { 0 };
> > struct platform_device *custom_pdev;
> > const char *dev_name;
> > char *c;
>
next prev parent reply other threads:[~2023-03-11 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 23:54 [PATCH] Fix buffer overrun in HID-SENSOR name Todd Brandt
2023-03-11 0:53 ` Philipp Jungkamp
2023-03-11 12:31 ` Jonathan Cameron [this message]
2023-03-13 16:56 ` srinivas pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311123148.0fbe1091@jic23-huawei \
--to=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.jungkamp@gmx.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=todd.e.brandt@intel.com \
--cc=todd.e.brandt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).