Re: [PATCH 2/2] iio: temperature: Add MCP9600 thermocouple EMF converter

From: kernel test robot <lkp@intel.com>
To: Andrew Hepp <andrew.hepp@ahepp.dev>,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Andrew Hepp <andrew.hepp@ahepp.dev>
Subject: Re: [PATCH 2/2] iio: temperature: Add MCP9600 thermocouple EMF converter
Date: Mon, 20 Mar 2023 05:24:35 +0800	[thread overview]
Message-ID: <202303200531.buTbR2TA-lkp@intel.com> (raw)
In-Reply-To: <20230319184728.49232-3-andrew.hepp@ahepp.dev>

Hi Andrew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.3-rc2 next-20230317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrew-Hepp/dt-bindings-iio-Add-MCP9600-thermocouple-EMF-converter/20230320-024950
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20230319184728.49232-3-andrew.hepp%40ahepp.dev
patch subject: [PATCH 2/2] iio: temperature: Add MCP9600 thermocouple EMF converter
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230320/202303200531.buTbR2TA-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/dc26dd0d9cb47654a6910bf35d8531b90ae88ece
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andrew-Hepp/dt-bindings-iio-Add-MCP9600-thermocouple-EMF-converter/20230320-024950
        git checkout dc26dd0d9cb47654a6910bf35d8531b90ae88ece
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/iio/temperature/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303200531.buTbR2TA-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iio/temperature/mcp9600.c: In function 'mcp9600_read':
>> drivers/iio/temperature/mcp9600.c:51:16: warning: unused variable 'buf' [-Wunused-variable]
      51 |         __be16 buf;
         |                ^~~

vim +/buf +51 drivers/iio/temperature/mcp9600.c

    47	
    48	static int mcp9600_read(struct mcp9600_data *data,
    49				struct iio_chan_spec const *chan, int *val)
    50	{
  > 51		__be16 buf;
    52		int ret;
    53	
    54		mutex_lock(&data->read_lock);
    55		ret = i2c_smbus_read_word_swapped(data->client, chan->address);
    56		mutex_unlock(&data->read_lock);
    57	
    58		if (ret < 0)
    59			return ret;
    60		*val = ret;
    61	
    62		return 0;
    63	}
    64	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests