From: Lars-Peter Clausen <lars@metafoo.de>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"hancock@sedsystems.ca" <hancock@sedsystems.ca>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "ardeleanalex@gmail.com" <ardeleanalex@gmail.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: adc: xilinx: support all platforms
Date: Tue, 11 Jun 2019 08:52:28 +0200 [thread overview]
Message-ID: <23b0143d-7089-cba0-813d-2634345a66c4@metafoo.de> (raw)
In-Reply-To: <2c4116f4923ac710de15c2980e620f9d59f902b6.camel@analog.com>
On 6/11/19 8:28 AM, Ardelean, Alexandru wrote:
> On Mon, 2019-06-10 at 10:23 -0600, Robert Hancock wrote:
>> [External]
>>
>>
>> Since the XADC logic can be used with standalone Xilinx FPGAs, this
>> driver can potentially be used with many different platforms, not just
>> the Zynq and MicroBlaze platforms this driver was allowed to be built
>> for. There should be no platform-specific code in this driver, so just
>> delete the platform dependency.
>>
>> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
>> ---
>>
>> This is an updated version of an earlier patch "iio: adc: xilinx: support all
>> ARM platforms", but this one just deletes the platform restriction entirely
>> as it seems unnecessary.
>>
>> drivers/iio/adc/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index f96a770..7e32862 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
>>
>> config XILINX_XADC
>> tristate "Xilinx XADC driver"
>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
>
> Just curios here: is `depends COMPILE_TEST` needed so that this gets included in a compile-test build ?
> I'm somewhat vague on Linux's makefile logic/structure.
COMPILE_TEST enables the driver for compile testing if it is not already
enabled otherwise. Now that the driver has no dependencies at all it
will always be enabled, which includes compile testing.
next prev parent reply other threads:[~2019-06-11 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:23 [PATCH] iio: adc: xilinx: support all platforms Robert Hancock
2019-06-11 6:28 ` Ardelean, Alexandru
2019-06-11 6:52 ` Lars-Peter Clausen [this message]
2019-06-11 6:57 ` Ardelean, Alexandru
2019-06-16 15:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23b0143d-7089-cba0-813d-2634345a66c4@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandru.Ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=hancock@sedsystems.ca \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).