From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Bakker <xc-racer2@live.ca>
Cc: "Kukjin Kim" <kgene@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells
Date: Tue, 8 Sep 2020 10:38:46 +0200 [thread overview]
Message-ID: <48aa966f-d3b8-7e4a-36aa-aed4630d331a@kernel.org> (raw)
In-Reply-To: <20200908065321.GB24227@pi3>
On 9/8/20 08:53, Krzysztof Kozlowski wrote:
> On Mon, Sep 07, 2020 at 04:55:26PM -0700, Jonathan Bakker wrote:
>> Sadly, this is causing issues for me. The machine driver is no longer probing correctly
>> on the Galaxy S.
>>
>> The failing call in sound/soc/samsung/aries_wm8994.c is
>>
>> /* Set CPU of_node for BT DAI */
>> aries_dai[2].cpus->of_node = of_parse_phandle(cpu,
>> "sound-dai", 1);
>>
>> where cpus->of_node is not set properly. Which is definitely weird because it doesn't
>> look like this should affect that.
>>
>> Let me know if there's any specific test that you want me to do.
> Thanks for the tests. I wonder now if this was working before because
> really my change should not break it... I'll think more about it.
I think of_parse_phandle_with_args() needs to be used instead of just
of_parse_phandle() for that to work, as AFAICS the latter assumes the
cells count == 0. We would need first to update the driver and then dts.
next prev parent reply other threads:[~2020-09-08 8:39 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:11 [PATCH 00/25] ARM: dts: s5pv210: Cleanup - dtschema warnings Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 01/25] dt-bindings: samsung: pmu: document S5Pv210 Krzysztof Kozlowski
2020-09-09 19:36 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 02/25] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Krzysztof Kozlowski
2020-09-07 16:38 ` Jonathan Cameron
2020-09-07 17:11 ` Krzysztof Kozlowski
2020-09-08 20:24 ` Rob Herring
2020-09-08 20:25 ` Rob Herring
2020-09-10 11:55 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Krzysztof Kozlowski
2020-09-07 16:39 ` Jonathan Cameron
2020-09-07 21:49 ` Jonathan Bakker
2020-09-08 6:48 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 04/25] ARM: dts: s5pv210: fix pinctrl property of "vibrator-en" regulator in Aries Krzysztof Kozlowski
2020-09-09 19:39 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 05/25] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Krzysztof Kozlowski
2020-09-07 21:56 ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node Krzysztof Kozlowski
2020-09-07 21:59 ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 07/25] ARM: dts: s5pv210: move PMU node out of clock controller Krzysztof Kozlowski
2020-09-07 22:02 ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Krzysztof Kozlowski
2020-09-07 22:41 ` Jonathan Bakker
2020-09-07 16:11 ` [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells Krzysztof Kozlowski
2020-09-07 23:55 ` Jonathan Bakker
2020-09-08 6:53 ` Krzysztof Kozlowski
2020-09-08 8:38 ` Sylwester Nawrocki [this message]
2020-09-07 16:11 ` [PATCH 10/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aquilla Krzysztof Kozlowski
2020-09-09 19:43 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family Krzysztof Kozlowski
2020-09-07 23:57 ` Jonathan Bakker
2020-09-08 6:54 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 12/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 13/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKC110 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 14/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKV210 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 15/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Torbreck Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 16/25] ARM: dts: s5pv210: use defines for GPIO flags in Aquila Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 17/25] ARM: dts: s5pv210: use defines for GPIO flags in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 18/25] ARM: dts: s5pv210: use defines for IRQ flags in SMDKV210 Krzysztof Kozlowski
2020-09-07 16:11 ` [PATCH 19/25] ARM: dts: s5pv210: use defines for IRQ flags in Goni Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 20/25] ARM: dts: s5pv210: move fixed regulators under root node in Aquila Krzysztof Kozlowski
2020-09-16 17:16 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 21/25] ARM: dts: s5pv210: move fixed regulators under root node in Goni Krzysztof Kozlowski
2020-09-16 17:16 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 22/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Aquila Krzysztof Kozlowski
2020-09-16 17:17 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 23/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Goni Krzysztof Kozlowski
2020-09-16 17:17 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 24/25] ARM: dts: s5pv210: align SPI GPIO node name with dtschema in Aries Krzysztof Kozlowski
2020-09-07 23:34 ` Jonathan Bakker
2020-09-09 19:44 ` Krzysztof Kozlowski
2020-09-07 16:11 ` [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema Krzysztof Kozlowski
2020-09-08 0:17 ` Jonathan Bakker
[not found] ` <25178674-e4af-ba35-b7f0-42091208e0e8@live.ca>
2020-09-08 0:28 ` Jonathan Bakker
2020-09-08 6:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48aa966f-d3b8-7e4a-36aa-aed4630d331a@kernel.org \
--to=snawrocki@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).