From: Todd Brandt <todd.e.brandt@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Todd Brandt <todd.e.brandt@intel.com>,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: srinivas.pandruvada@linux.intel.com, jic23@kernel.org,
jikos@kernel.org, p.jungkamp@gmx.net
Subject: Re: [PATCH v2] Fix buffer overrun in HID-SENSOR name string
Date: Wed, 15 Mar 2023 13:35:42 -0700 [thread overview]
Message-ID: <4aef4cd04a499c022c64c5e0276ce36f9ff3eacf.camel@linux.intel.com> (raw)
In-Reply-To: <cdfe3d41-5ea4-c6a8-fbab-4920d08c6303@kernel.org>
On Wed, 2023-03-15 at 08:04 +0100, Krzysztof Kozlowski wrote:
> On 13/03/2023 23:06, Todd Brandt wrote:
> > On some platforms there are some platform devices created with
> > invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead
> > of "HID-SENSOR-INT-020b.39.auto"
> >
> > This string include some invalid characters, hence it will fail to
> > properly load the driver which will handle this custom sensor. Also
> > it is a problem for some user space tools, which parse the device
> > names from ftrace and dmesg.
> >
> > This is because the string, real_usage, is not NULL terminated and
> > printed with %s to form device name.
> >
> > To address this, we initialize the real_usage string with 0s.
> >
> > Philipp Jungkamp created this fix, I'm simply submitting it. I've
> > verified it fixes bugzilla issue 217169
> >
> > Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
>
> SoB denotes that you reported this and tested. Otherwise shall we
> start
> adding Reported and Tested tags to all of our commits?
>
I just copied it from someone else's post on the mailing list, I
thought it was part of the standard lkml vernacular but I just looked
it up and it's explicitly forbidden in
Documentation/process/maintainer-top.rst line 385. So the answer is no.
I'll not use it again.
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-03-15 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 22:06 [PATCH v2] Fix buffer overrun in HID-SENSOR name string Todd Brandt
2023-03-13 23:07 ` Andi Shyti
2023-03-13 23:37 ` Todd Brandt
2023-03-14 1:07 ` srinivas pandruvada
2023-03-15 7:04 ` Krzysztof Kozlowski
2023-03-15 20:35 ` Todd Brandt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aef4cd04a499c022c64c5e0276ce36f9ff3eacf.camel@linux.intel.com \
--to=todd.e.brandt@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.jungkamp@gmx.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).