From: Sean Nyekjaer <sean@geanix.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v5 2/6] iio: imu: st_lsm6dsx: add motion events
Date: Mon, 9 Sep 2019 12:26:38 +0200 [thread overview]
Message-ID: <4e87bfae-ea15-a325-b4eb-232e6a370581@geanix.com> (raw)
In-Reply-To: <20190909102117.GA2990@localhost.localdomain>
On 09/09/2019 12.21, Lorenzo Bianconi wrote:
> You defined wakeup_src_{w,y,z}_mask in patch 5/6 and you are using them here. Please do not do so since you are breaking 'git bisect'
>
> Regards,
> Lorenzo
My bad, will update in v6 :)
Will move the device sensor definitions to 5/6, so we avoid
"warning: variable ‘**’ set but not used"
/Sean
next prev parent reply other threads:[~2019-09-09 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 9:45 [PATCH v5 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-09 9:45 ` [PATCH v5 2/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-09 10:21 ` Lorenzo Bianconi
2019-09-09 10:26 ` Sean Nyekjaer [this message]
2019-09-09 11:13 ` Sean Nyekjaer
2019-09-09 9:45 ` [PATCH v5 3/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-09 9:45 ` [PATCH v5 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-09 9:45 ` [PATCH v5 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-09 9:45 ` [PATCH v5 6/6] iio: imu: st_lsm6dsx: prohibit the use of events and buffered reads simultaneously Sean Nyekjaer
2019-09-09 9:56 ` [PATCH v5.1 " Sean Nyekjaer
2019-09-09 10:40 ` Lorenzo Bianconi
2019-09-09 11:07 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e87bfae-ea15-a325-b4eb-232e6a370581@geanix.com \
--to=sean@geanix.com \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).