From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Gwendal Grignou <gwendal@chromium.org>,
jic23@kernel.org, bleung@chromium.org, groeck@chromium.org,
fabien.lahoudere@collabora.com, dianders@chromium.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Support accelerometers for veyron_minnie
Date: Tue, 25 Jun 2019 19:09:50 +0200 [thread overview]
Message-ID: <5326bfb8-611f-765b-1c9c-c95032102c71@collabora.com> (raw)
In-Reply-To: <20190624225312.131745-1-gwendal@chromium.org>
Hi,
On 25/6/19 0:53, Gwendal Grignou wrote:
> veyron_minnie - ASUS Chromebook Flip C100PA - embedded controller
> controls two accelerometers, one in the lid, one in the base.
> However, the EC firmware does not follow the new interface that
> cros_ec_accel driver use.
> Extend the legacy driver used on glimmer - Lenovo ThinkPad 11e
> Chromebook - to veyron_minnie.
> veyron_minnie being ARM based, issue command over the I2C bus to the EC
> instead of relying on the shared registers over LPC.
>
> Gwendal Grignou (2):
> iio: cros_ec: Add sign vector in core for backward compatibility
> iio: cros_ec: Extend legacy support to ARM device
>
> Changes in v3:
> - Fix commit message, add reviewed-by for first patch.
>
> Changes in v2:
> - Readd empty line to reduce amount of change in patch.
> - Remove Keywords used by ChromeOS commit queue.
>
> drivers/iio/accel/Kconfig | 4 +-
> drivers/iio/accel/cros_ec_accel_legacy.c | 350 ++++--------------
> .../cros_ec_sensors/cros_ec_sensors_core.c | 4 +
> .../linux/iio/common/cros_ec_sensors_core.h | 1 +
> 4 files changed, 84 insertions(+), 275 deletions(-)
>
Just a side note that I think that this patch depends on [1] to have the legacy
sensors working on veyron minnie.
For the full series:
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
[1] https://lkml.org/lkml/2019/6/18/268
next prev parent reply other threads:[~2019-06-25 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 22:53 [PATCH v3 0/2] Support accelerometers for veyron_minnie Gwendal Grignou
2019-06-24 22:53 ` [PATCH v3 1/2] iio: cros_ec: Add sign vector in core for backward compatibility Gwendal Grignou
2019-06-24 22:53 ` [PATCH v3 2/2] iio: cros_ec: Extend legacy support to ARM device Gwendal Grignou
2019-06-26 21:05 ` Doug Anderson
2019-06-27 15:35 ` Enric Balletbo Serra
2019-06-25 17:09 ` Enric Balletbo i Serra [this message]
2019-06-26 19:21 ` [PATCH v3 0/2] Support accelerometers for veyron_minnie Jonathan Cameron
2019-06-26 20:40 ` Enric Balletbo i Serra
2019-06-26 20:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5326bfb8-611f-765b-1c9c-c95032102c71@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=fabien.lahoudere@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).