From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chun-Hung Wu <chun-hung.wu@mediatek.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
wsd_upstream@mediatek.com, peter.wang@mediatek.com,
kuohong.wang@mediatek.com, jg_poxu@mediatek.com
Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support
Date: Wed, 22 May 2019 18:28:50 +0200 [thread overview]
Message-ID: <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> (raw)
In-Reply-To: <1558332205.11080.6.camel@mtkswgap22>
On 20/05/2019 08:03, Chun-Hung Wu wrote:
> Hi Jonathan:
>
> Thanks for the prompt reply,
>
> On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote:
>> On Thu, 16 May 2019 16:10:46 +0800
>> Chun-Hung Wu <chun-hung.wu@mediatek.com> wrote:
>>
>>> Move suspend/resume to late_suspend and
>>> early_resume to gurantee users can use auxadc
>> guarantee
>>
> will fix it in next version.
>>> driver at suspend/resume stage.
>> No problem with the patch content, but we need a reason why they may
>> want to do so?
> Our thermal drivers uses auxadc at suspend/resume stage.
> In order to avoid auxadc suspended prior to thermal driver,
> we move auxadc to late_suspend and early_resume.
>
That sounds like a user of device_links [1] to me.
[1] https://www.kernel.org/doc/html/latest/driver-api/device_link.html
> Thanks,
> Chun-Hung
>>
>> Thanks,
>>
>> Jonathan
>>>
>>> Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
>>> ---
>>> drivers/iio/adc/mt6577_auxadc.c | 7 ++++---
>>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
>>> index e1bdcc0..58d7cb2 100644
>>> --- a/drivers/iio/adc/mt6577_auxadc.c
>>> +++ b/drivers/iio/adc/mt6577_auxadc.c
>>> @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev)
>>> return 0;
>>> }
>>>
>>> -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops,
>>> - mt6577_auxadc_suspend,
>>> - mt6577_auxadc_resume);
>>> +static const struct dev_pm_ops mt6577_auxadc_pm_ops = {
>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend,
>>> + mt6577_auxadc_resume)
>>> +};
>>>
>>> static const struct of_device_id mt6577_auxadc_of_match[] = {
>>> { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat},
>>
>
>
next prev parent reply other threads:[~2019-05-22 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 8:10 [PATCH 0/4] iio: adc: mediatek: add mt6765 driver support Chun-Hung Wu
2019-05-16 8:10 ` [PATCH 1/4] dt-bindings: iio: adc: mediatek: Add document for mt6765 Chun-Hung Wu
2019-05-18 10:33 ` Jonathan Cameron
2019-05-20 6:47 ` Chun-Hung Wu
2019-05-16 8:10 ` [PATCH 2/4] iio: adc: mediatek: mt6765 upstream driver Chun-Hung Wu
2019-05-18 10:33 ` Jonathan Cameron
2019-05-16 8:10 ` [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support Chun-Hung Wu
2019-05-18 10:35 ` Jonathan Cameron
2019-05-20 6:03 ` Chun-Hung Wu
2019-05-22 16:28 ` Matthias Brugger [this message]
2019-05-28 10:59 ` Chun-Hung Wu
2019-06-06 15:46 ` Jonathan Cameron
2019-05-16 8:10 ` [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall Chun-Hung Wu
2019-05-18 10:36 ` Jonathan Cameron
2019-05-20 6:06 ` Chun-Hung Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7838dcae-8a69-0297-718b-a061b14a456d@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chun-hung.wu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jg_poxu@mediatek.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kuohong.wang@mediatek.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=peter.wang@mediatek.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).