From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] iio: frequency: ad9523: convert rest of driver to device managed functions
Date: Wed, 22 Jul 2020 10:02:05 +0300 [thread overview]
Message-ID: <CA+U=DsopNdqrEdnjY2r3mfd1bqeTR81PdH1mbtXSGHzUEpbarQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfY_6pg=6atYwd=JcPd1MZqHZh5Dj_QYdQyS=5ENHL5aQ@mail.gmail.com>
On Tue, Jul 21, 2020 at 10:34 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Jul 21, 2020 at 2:27 PM Alexandru Ardelean
> <alexandru.ardelean@analog.com> wrote:
> >
> > The driver pretty much uses device managed functions. The only left-over is
> > the iio_device_register() function, which also requires an action-or-reset
> > hook to disable the regulator on the remove and error path.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> ...
>
>
> > + ret = devm_iio_device_register(&spi->dev, indio_dev);
> > + if (ret == 0)
>
> > + dev_info(&spi->dev, "probed %s\n", indio_dev->name);
> >
> > return ret;
>
> Please, drop this useless spam (I agree here with Greg KH) and use simply
> return devm_iio_...(...);
I was also a bit undecided whether to keep it.
Will drop.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-07-22 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 11:24 [PATCH] iio: frequency: ad9523: convert rest of driver to device managed functions Alexandru Ardelean
2020-07-21 19:33 ` Andy Shevchenko
2020-07-22 7:02 ` Alexandru Ardelean [this message]
2020-07-22 7:22 ` [PATCH v2] " Alexandru Ardelean
2020-07-26 12:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=DsopNdqrEdnjY2r3mfd1bqeTR81PdH1mbtXSGHzUEpbarQ@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).