From: Doug Anderson <dianders@chromium.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Fabien Lahoudere <fabien.lahoudere@collabora.com>,
linux-iio <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: cros_ec: Add sign vector in core for backward compatibility
Date: Mon, 24 Jun 2019 11:05:18 -0700 [thread overview]
Message-ID: <CAD=FV=VoW7Yc8jET4AAu2jD2K1wm6W25KSKn8UbhZKxFLQsiHg@mail.gmail.com> (raw)
In-Reply-To: <20190621024106.158589-2-gwendal@chromium.org>
Hi,
On Thu, Jun 20, 2019 at 7:41 PM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> To allow cros_ec iio core library to be used with legacy device, add a
> vector to rotate sensor data if necessary: legacy devices are not
> reporting data in HTML5/Android sensor referential.
>
> On veyron minnie, check chrome detect tablet mode and rotate
> screen in tablet mode.
The above sentence is still a little strange. You just took the
"TEST=" out but still left the testing instructions? They sound odd
like this. You could just drop it, or perhaps instead change to:
This change is part of a set of changes needed to let Chrome detect
tablet mode and screen rotation on rk3288-veyron-minnie.
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 4 ++++
> include/linux/iio/common/cros_ec_sensors_core.h | 1 +
> 2 files changed, 5 insertions(+)
I'm decidedly a non-expert here, but since I had nitpicks on patch #1
and my nitpicks have been addressed, feel free to add:
Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2019-06-24 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 2:41 [PATCH 0/2] Support accelerometers for veyron_minnie Gwendal Grignou
2019-06-21 2:41 ` [PATCH v2 1/2] iio: cros_ec: Add sign vector in core for backward compatibility Gwendal Grignou
2019-06-22 8:54 ` Jonathan Cameron
2019-06-24 22:44 ` Gwendal Grignou
2019-06-24 18:05 ` Doug Anderson [this message]
2019-06-21 2:41 ` [PATCH v2 2/2] iio: cros_ec : Extend legacy support to ARM device Gwendal Grignou
2019-06-22 9:03 ` Jonathan Cameron
2019-06-28 18:55 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VoW7Yc8jET4AAu2jD2K1wm6W25KSKn8UbhZKxFLQsiHg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).