From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>,
Rohit Sarkar <rohitsarkar5398@gmail.com>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface
Date: Sat, 21 Mar 2020 21:53:23 +0200 [thread overview]
Message-ID: <CAHp75VcUtMZDMqizhW=oayvbGcMTZ9M0s=7L0TngkdXz=M49uQ@mail.gmail.com> (raw)
In-Reply-To: <20200321183154.128d8920@archlinux>
On Sat, Mar 21, 2020 at 8:31 PM Jonathan Cameron
<jic23@jic23.retrosnub.co.uk> wrote:
> On Thu, 19 Mar 2020 11:08:44 +0000
> Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote:
> > iio debugfs register interface is quite handy because we can read a single register and write a value.
> >
> > regmap debugfs is only a dump of all registers, as far as I know (may have missed something).
>
> So this is something Mark has discussed before around regmap
> and more generally IIRC. The issue is that a write
> interface does make it somewhat easy to do really nasty things
> in some drivers that use regmap (to the extent of setting boards
> on fire etc). For IIO we are much safer - the worst you can do
> is break the IIO driver.
Sometimes IIO driver provides a sensor data about platform facilities,
such as temperature of the die / chip or battery voltage threshold.
> I've never been that fussed myself about the debugfs interfaces
> as it's easy to hack them in when needed for actual debugging, but
> have taken the view that if someone has enough of a usecase to
> want to add them to a particular driver, then it's up to them.
Good to know your p.o.v.!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-21 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 6:07 [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface Rohit Sarkar
2020-03-19 10:24 ` Andy Shevchenko
2020-03-19 11:08 ` Jean-Baptiste Maneyrol
2020-03-21 18:31 ` Jonathan Cameron
2020-03-21 19:53 ` Andy Shevchenko [this message]
2020-03-27 10:56 ` Jean-Baptiste Maneyrol
2020-03-27 12:42 ` Rohit Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcUtMZDMqizhW=oayvbGcMTZ9M0s=7L0TngkdXz=M49uQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=JManeyrol@invensense.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=rohitsarkar5398@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).