linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jimmy Assarsson <jimmyassarsson@gmail.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH 2/2] iio: imu: st_lsm6dsx: Add sensor hub device LIS3MDL
Date: Wed, 25 Mar 2020 13:02:14 +0200	[thread overview]
Message-ID: <CAHp75VcoVpPvhGQR6D5riLN7DUr+n9FdC-qDwvTHZNF5fnYp7g@mail.gmail.com> (raw)
In-Reply-To: <9f984a4d-b8df-2459-c330-409277b14c3e@gmail.com>

On Tue, Mar 24, 2020 at 11:59 PM Jimmy Assarsson
<jimmyassarsson@gmail.com> wrote:
> On 2020-03-24 22:52, Jimmy Assarsson wrote:

...

> > +             .wai = {
> > +                     .addr = 0x0f,
>
> In st_magn_core.c this is ST_SENSORS_DEFAULT_WAI_ADDRESS
> (from linux/iio/common/st_sensors.h). Is this OK, our should I change it?

I would rather use macro, Easier to grep what is being used with ST sensors.

>
> > +                     .val = 0x3d,
> > +             },


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2020-03-25 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24 21:52 [PATCH 1/2] iio: imu: st_lsm6dsx: Increase ODR_LIST_SIZE Jimmy Assarsson
2020-03-24 21:52 ` [PATCH 2/2] iio: imu: st_lsm6dsx: Add sensor hub device LIS3MDL Jimmy Assarsson
2020-03-24 21:58   ` Jimmy Assarsson
2020-03-25 11:02     ` Andy Shevchenko [this message]
2020-03-25 18:57       ` Jimmy Assarsson
2020-04-04 15:36 ` [PATCH 1/2] iio: imu: st_lsm6dsx: Increase ODR_LIST_SIZE Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VcoVpPvhGQR6D5riLN7DUr+n9FdC-qDwvTHZNF5fnYp7g@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=jimmyassarsson@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).