From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: trix@redhat.com
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: check st_lsm6dsx_shub_read_output return
Date: Mon, 10 Aug 2020 11:08:39 +0300 [thread overview]
Message-ID: <CAHp75Vcomp1mDUm5houAm2j2b2HtxAP8Z78Vfcdmgm_g+bbt7w@mail.gmail.com> (raw)
In-Reply-To: <20200809175551.6794-1-trix@redhat.com>
On Sun, Aug 9, 2020 at 8:56 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this represenative problem
>
> st_lsm6dsx_shub.c:540:8: warning: Assigned value is garbage or undefined
> *val = (s16)le16_to_cpu(*((__le16 *)data));
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> data is set with
>
> err = st_lsm6dsx_shub_read(sensor, ch->address, data, len);
> if (err < 0)
> return err;
>
> The problem with st_lsm6dsx_shub_read() is this statement
>
> err = st_lsm6dsx_shub_read_output(hw, data,
> len & ST_LS6DSX_READ_OP_MASK);
>
> The err value is never checked.
> So check err.
>
> Fixes: c91c1c844ebd ("iio: imu: st_lsm6dsx: add i2c embedded controller support")
>
> Signed-off-by: Tom Rix <trix@redhat.com>
You see, the commit message can be divided to three sections
1. Title / very short description
2. Detailed description
3. Tag block
Each of them has some specific rules:
1. One quite short line prefixed by subsystem / driver in the
specified format (usually gathered by reading git log against the
module in question)
2. Should explain why this change is done
3. Should be one tag -- one line, no blank lines in between.
Hope, you will use this in the future.
After addressing that (perhaps Jonathan will do it for you)
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> index ed83471dc7dd..8c8d8870ca07 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> @@ -313,6 +313,8 @@ st_lsm6dsx_shub_read(struct st_lsm6dsx_sensor *sensor, u8 addr,
>
> err = st_lsm6dsx_shub_read_output(hw, data,
> len & ST_LS6DSX_READ_OP_MASK);
> + if (err < 0)
> + return err;
>
> st_lsm6dsx_shub_master_enable(sensor, false);
>
> --
> 2.18.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-10 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 17:55 [PATCH] iio: imu: st_lsm6dsx: check st_lsm6dsx_shub_read_output return trix
2020-08-10 8:08 ` Andy Shevchenko [this message]
2020-09-19 15:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vcomp1mDUm5houAm2j2b2HtxAP8Z78Vfcdmgm_g+bbt7w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).