From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Sean Nyekjaer" <sean@geanix.com>,
"Jonathan Cameron" <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"Nuno Sá" <Nuno.Sa@analog.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] iio: accel: fxls8962af: add interrupt support
Date: Thu, 29 Apr 2021 12:35:02 +0300 [thread overview]
Message-ID: <CAHp75Vd1j=rqmzEuo9fQMYDc+Y1=8kfyVJq6VR4Oip-O918Xow@mail.gmail.com> (raw)
In-Reply-To: <28f1e2a4-b2fa-5e4a-954f-92d90966eaf7@metafoo.de>
On Thu, Apr 29, 2021 at 11:58 AM Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 4/28/21 10:22 AM, Sean Nyekjaer wrote:
> > Preparation commit for the next that adds hw buffered sampling
...
> > + irq = of_irq_get_byname(of_node, "INT2");
>
> For this I'd use device_property_match_string(dev, "interrupt-names",
> "INT2"). Means it won't try to map the interrupt again, and also this is
> the only place where the driver directly depends on OF, everything else
> already uses the device_ API.
Why not platform_get_irq_byname_optional() ?
> > + if (irq > 0) {
> > + *pin = FXLS8962AF_PIN_INT2;
> > + return;
> > + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-29 9:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 8:22 [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Sean Nyekjaer
2021-04-28 8:22 ` [RFC PATCH 2/4] iio: accel: fxls8962af: add interrupt support Sean Nyekjaer
2021-04-28 14:26 ` Jonathan Cameron
2021-04-29 8:58 ` Lars-Peter Clausen
2021-04-29 9:35 ` Andy Shevchenko [this message]
2021-04-29 9:37 ` Lars-Peter Clausen
2021-04-29 11:35 ` Andy Shevchenko
2021-04-29 19:19 ` Lars-Peter Clausen
2021-04-30 8:54 ` Andy Shevchenko
2021-04-28 8:22 ` [RFC PATCH 3/4] iio: accel: fxls8962af: add hw buffered sampling Sean Nyekjaer
2021-04-28 11:05 ` Sean Nyekjaer
2021-04-28 13:53 ` Jonathan Cameron
2021-04-28 16:32 ` Jonathan Cameron
2021-04-29 7:40 ` Sean Nyekjaer
2021-04-29 14:52 ` Jonathan Cameron
2021-04-28 8:22 ` [RFC PATCH 4/4] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads Sean Nyekjaer
2021-04-28 11:24 ` Andy Shevchenko
2021-04-28 11:37 ` Sean Nyekjaer
2021-04-28 13:56 ` [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Jonathan Cameron
2021-05-03 19:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd1j=rqmzEuo9fQMYDc+Y1=8kfyVJq6VR4Oip-O918Xow@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Nuno.Sa@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).