From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia
Date: Wed, 2 Sep 2020 21:11:40 +0300 [thread overview]
Message-ID: <CAHp75Vd3sT6Vuovsy8YQg+pdqQd3s4vU8PQNNQvUruKZOiRSAw@mail.gmail.com> (raw)
In-Reply-To: <20200902145957.13861-1-krzk@kernel.org>
On Wed, Sep 2, 2020 at 6:04 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Emails to Beniamin Bia bounce with no such address so remove him from
> maintainers. After this removal, many entries for Analog Devices Inc
> IIO drivers look exactly the same so consolidate them.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
But nit-pick below.
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: linux-iio <linux-iio@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Consolidate IIO entries
> ---
> MAINTAINERS | 56 ++++-------------------------------------------------
> 1 file changed, 4 insertions(+), 52 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8107b3d5d6df..facffcf7b1d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -950,38 +950,6 @@ S: Supported
> F: arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
> F: drivers/net/ethernet/amd/xgbe/
>
> -ANALOG DEVICES INC AD5686 DRIVER
> -M: Michael Hennerich <Michael.Hennerich@analog.com>
> -L: linux-pm@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: drivers/iio/dac/ad5686*
> -F: drivers/iio/dac/ad5696*
> -
> -ANALOG DEVICES INC AD5758 DRIVER
> -M: Michael Hennerich <Michael.Hennerich@analog.com>
> -L: linux-iio@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: Documentation/devicetree/bindings/iio/dac/ad5758.txt
> -F: drivers/iio/dac/ad5758.c
> -
> -ANALOG DEVICES INC AD7091R5 DRIVER
> -M: Beniamin Bia <beniamin.bia@analog.com>
> -L: linux-iio@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> -F: drivers/iio/adc/ad7091r5.c
> -
> -ANALOG DEVICES INC AD7124 DRIVER
> -M: Michael Hennerich <Michael.Hennerich@analog.com>
> -L: linux-iio@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
> -F: drivers/iio/adc/ad7124.c
> -
> ANALOG DEVICES INC AD7192 DRIVER
> M: Alexandru Tachici <alexandru.tachici@analog.com>
> L: linux-iio@vger.kernel.org
> @@ -998,15 +966,6 @@ W: http://ez.analog.com/community/linux-device-drivers
> F: Documentation/devicetree/bindings/iio/adc/adi,ad7292.yaml
> F: drivers/iio/adc/ad7292.c
>
> -ANALOG DEVICES INC AD7606 DRIVER
> -M: Michael Hennerich <Michael.Hennerich@analog.com>
> -M: Beniamin Bia <beniamin.bia@analog.com>
> -L: linux-iio@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> -F: drivers/iio/adc/ad7606.c
> -
> ANALOG DEVICES INC AD7768-1 DRIVER
> M: Michael Hennerich <Michael.Hennerich@analog.com>
> L: linux-iio@vger.kernel.org
> @@ -1068,7 +1027,6 @@ F: drivers/iio/imu/adis16475.c
> F: Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
>
> ANALOG DEVICES INC ADM1177 DRIVER
> -M: Beniamin Bia <beniamin.bia@analog.com>
> M: Michael Hennerich <Michael.Hennerich@analog.com>
> L: linux-hwmon@vger.kernel.org
> S: Supported
> @@ -1135,15 +1093,6 @@ S: Supported
> W: http://ez.analog.com/community/linux-device-drivers
> F: drivers/dma/dma-axi-dmac.c
>
> -ANALOG DEVICES INC HMC425A DRIVER
> -M: Beniamin Bia <beniamin.bia@analog.com>
> -M: Michael Hennerich <michael.hennerich@analog.com>
> -L: linux-iio@vger.kernel.org
> -S: Supported
> -W: http://ez.analog.com/community/linux-device-drivers
> -F: Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> -F: drivers/iio/amplifiers/hmc425a.c
> -
> ANALOG DEVICES INC IIO DRIVERS
> M: Lars-Peter Clausen <lars@metafoo.de>
> M: Michael Hennerich <Michael.Hennerich@analog.com>
> @@ -1152,8 +1101,12 @@ W: http://wiki.analog.com/
> W: http://ez.analog.com/community/linux-device-drivers
> F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
> F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
> +F: Documentation/devicetree/bindings/iio/adc/adi*
> +F: Documentation/devicetree/bindings/iio/amplifiers/adi*
I would rather see one line like
F: Documentation/devicetree/bindings/iio/*/adi,*
Since we know that vendor,part-number is guaranteed by DT binding naming schema.
> +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt
> F: drivers/iio/*/ad*
> F: drivers/iio/adc/ltc249*
> +F: drivers/iio/amplifiers/hmc425a.c
> F: drivers/staging/iio/*/ad*
> X: drivers/iio/*/adjd*
>
> @@ -16537,7 +16490,6 @@ F: drivers/staging/rtl8712/
>
> STAGING - SEPS525 LCD CONTROLLER DRIVERS
> M: Michael Hennerich <michael.hennerich@analog.com>
> -M: Beniamin Bia <beniamin.bia@analog.com>
> L: linux-fbdev@vger.kernel.org
> S: Supported
> F: Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-02 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 14:59 [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia Krzysztof Kozlowski
2020-09-02 14:59 ` [PATCH v2 2/2] MAINTAINERS: Move Hartmut Knaack to Credits Krzysztof Kozlowski
2020-09-02 18:13 ` Andy Shevchenko
2020-09-02 15:05 ` [PATCH v2 1/2] MAINTAINERS: Consolidate Analog Devices IIO entries and remove Beniamin Bia Jonathan Cameron
2020-09-02 18:11 ` Andy Shevchenko [this message]
2020-09-02 18:54 ` Joe Perches
2020-09-02 19:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd3sT6Vuovsy8YQg+pdqQd3s4vU8PQNNQvUruKZOiRSAw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).