From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()'
Date: Wed, 6 May 2020 13:38:22 +0300 [thread overview]
Message-ID: <CAHp75Vdi+ZYpQPHgoREQ6LTaUHTPmNkR7ULZaVNTJr7Bvh-q9Q@mail.gmail.com> (raw)
In-Reply-To: <20200506035206.192173-1-christophe.jaillet@wanadoo.fr>
On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
> call.
> Remove it.
>
> While at it add a missing \n at the end of the message.
>
It should have Fixes tag because it is a quite an issue (get_device()
breaks reference counting with all problems we may expect).
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is purely speculative.
> I've looked a bit arround and see no point for this get_device() but other
> eyes are welcomed :)
> ---
> drivers/iio/accel/sca3000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index 66d768d971e1..6e429072e44a 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state *st,
> st->tx[0] = SCA3000_READ_REG(reg_address_high);
> ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer));
> if (ret) {
> - dev_err(get_device(&st->us->dev), "problem reading register");
> + dev_err(&st->us->dev, "problem reading register\n");
> return ret;
> }
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-06 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 3:52 [PATCH] iio: sca3000: Remove an erroneous 'get_device()' Christophe JAILLET
2020-05-06 10:38 ` Andy Shevchenko [this message]
2020-05-06 17:31 ` Marion & Christophe JAILLET
2020-05-08 13:02 ` Jonathan Cameron
2020-05-10 9:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vdi+ZYpQPHgoREQ6LTaUHTPmNkR7ULZaVNTJr7Bvh-q9Q@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).