From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tomasz Duszynski <tomasz.duszynski@octakon.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/6] iio: chemical: scd30: add serial interface driver
Date: Wed, 22 Apr 2020 22:55:05 +0300 [thread overview]
Message-ID: <CAHp75VeXd7hgdZ-1FDCpyad7_rHV1ERiigctn-6AYvVhLyX5QA@mail.gmail.com> (raw)
In-Reply-To: <20200422141135.86419-4-tomasz.duszynski@octakon.com>
On Wed, Apr 22, 2020 at 5:22 PM Tomasz Duszynski
<tomasz.duszynski@octakon.com> wrote:
>
> Add serial interface driver for the SCD30 sensor.
...
> +#include <linux/of_irq.h>
Do you need this?
> +static int scd30_serdev_probe(struct serdev_device *serdev)
> +{
> + struct device *dev = &serdev->dev;
> + struct scd30_serdev_priv *priv;
> + int irq, ret;
> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> + irq = of_irq_get(dev->of_node, 0);
fwnode_irq_get() ?
> + if (irq <= 0)
> + irq = 0;
> +
> + return scd30_probe(dev, irq, KBUILD_MODNAME, priv,
> + scd30_serdev_command);
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-22 19:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 14:11 [PATCH 0/6] Add support for SCD30 sensor Tomasz Duszynski
2020-04-22 14:11 ` [PATCH 1/6] iio: chemical: scd30: add core driver Tomasz Duszynski
2020-04-22 19:49 ` Andy Shevchenko
2020-04-24 19:04 ` Tomasz Duszynski
2020-04-25 11:43 ` Andy Shevchenko
2020-04-25 17:59 ` Jonathan Cameron
2020-04-25 18:41 ` Tomasz Duszynski
2020-04-25 18:52 ` Andy Shevchenko
2020-04-28 7:56 ` Tomasz Duszynski
2020-04-28 10:16 ` Andy Shevchenko
2020-04-28 14:06 ` Tomasz Duszynski
2020-04-25 18:55 ` Jonathan Cameron
2020-04-25 19:00 ` Jonathan Cameron
2020-04-28 7:51 ` Tomasz Duszynski
2020-05-02 16:37 ` Jonathan Cameron
2020-05-03 10:53 ` Tomasz Duszynski
2020-04-22 14:11 ` [PATCH 2/6] iio: chemical: scd30: add I2C interface driver Tomasz Duszynski
2020-04-22 14:11 ` [PATCH 3/6] iio: chemical: scd30: add serial " Tomasz Duszynski
2020-04-22 19:55 ` Andy Shevchenko [this message]
2020-04-23 16:23 ` Tomasz Duszynski
2020-04-22 14:11 ` [PATCH 4/6] Documentation: ABI: testing: scd30: document iio attributes Tomasz Duszynski
2020-04-22 16:40 ` Peter Meerwald-Stadler
2020-04-23 15:53 ` Tomasz Duszynski
2020-04-25 19:20 ` Jonathan Cameron
2020-04-26 11:11 ` Tomasz Duszynski
2020-04-27 9:44 ` Jonathan Cameron
2020-04-22 14:11 ` [PATCH 5/6] dt-bindings: iio: scd30: add device binding file Tomasz Duszynski
2020-04-25 19:23 ` Jonathan Cameron
2020-04-26 8:28 ` Tomasz Duszynski
2020-04-27 21:28 ` Rob Herring
2020-04-28 8:10 ` Tomasz Duszynski
2020-04-22 14:11 ` [PATCH 6/6] MAINTAINERS: add myself as a SCD30 driver maintainer Tomasz Duszynski
2020-04-22 19:25 ` Andy Shevchenko
2020-04-23 16:01 ` Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeXd7hgdZ-1FDCpyad7_rHV1ERiigctn-6AYvVhLyX5QA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.duszynski@octakon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).