From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Daniel Campello <campello@google.com>
Cc: LKML <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
Enrico Granata <egranata@chromium.org>,
Andreas Klinger <ak@it-klinger.de>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver
Date: Tue, 14 Apr 2020 12:10:56 +0300 [thread overview]
Message-ID: <CAHp75VemvD0mvDHWorSFhqOKaQ1Y_vLYVAQmnb8iz30AH431+Q@mail.gmail.com> (raw)
In-Reply-To: <CAHcu+VZMiFVt9L9kNCTtsmxUP-7tO+pBpCOtMHQPotuye_2w1A@mail.gmail.com>
On Tue, Apr 14, 2020 at 1:56 AM Daniel Campello <campello@google.com> wrote:
> On Fri, Apr 10, 2020 at 4:52 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Apr 9, 2020 at 2:54 AM Daniel Campello <campello@chromium.org> wrote:
As far I understand you agreed on the rest.
Correct?
...
> > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > > Signed-off-by: Enrico Granata <egranata@chromium.org>
> >
> > This is not understandable. Are they who helped you develop the code
> > (we have a special tag, i.e. Co-developed-by in addition to SoB), or
> > just people in the middle? Then the question is, how come author is
> > you and not Gwendal?
> >
> This patch was initially developed by Gwendal and Enrico (here:
> crrev.com/c/1089826).
So, tags should include
SoB: Gwendal ...
Co-developed-by: Enrico ...
SoB: Enrico ...
Co-developed-by: yours (if you developed it)
SoB: yours
and on top git commit --amend --author="Gwendal ..."
...
> > > +#define SX9310_REG_IRQ_MSK 0x03
> >
> > Is MSK abbreviation in datasheet? Please spell it how it's in datasheet.
> Yes, they indead use MSK.
Okay!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-14 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 23:53 [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver Daniel Campello
2020-04-10 10:52 ` Andy Shevchenko
2020-04-12 10:56 ` Jonathan Cameron
2020-04-13 22:55 ` Daniel Campello
2020-04-14 9:10 ` Andy Shevchenko [this message]
2020-04-14 20:41 ` Daniel Campello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VemvD0mvDHWorSFhqOKaQ1Y_vLYVAQmnb8iz30AH431+Q@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=ak@it-klinger.de \
--cc=campello@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=egranata@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).