From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: Dan Robertson <dan@dlrobertson.com>,
kbuild-all@lists.01.org, Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
devicetree <devicetree@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: (bma400) add driver for the BMA400
Date: Tue, 15 Oct 2019 16:53:16 +0300 [thread overview]
Message-ID: <CAHp75VeyB2rZXXF34cUKp2iBfJMeN3fw8SfBMW=13sZY3z2DNA@mail.gmail.com> (raw)
In-Reply-To: <201910150017.MkSBCEcB%lkp@intel.com>
On Tue, Oct 15, 2019 at 12:25 AM kbuild test robot <lkp@intel.com> wrote:
> smatch warnings:
> drivers/iio/accel/bma400_core.c:422 bma400_set_accel_oversampling_ratio() warn: unsigned 'acc_config' is never less than zero.
> 420 ret = regmap_read(data->regmap, BMA400_ACC_CONFIG0_REG,
> 421 &acc_config);
> > 422 if (acc_config < 0)
> 423 return acc_config;
Obvious typo, has to be if (ret < 0)
> 424
> 425 ret = regmap_write(data->regmap, BMA400_ACC_CONFIG0_REG,
> 426 (acc_config & ~BMA400_LP_OSR_MASK) |
> 427 (val << BMA400_LP_OSR_SHIFT));
> 428 if (ret < 0) {
> 429 dev_err(data->dev, "Failed to write out OSR");
> 430 return ret;
> 431 }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-10-15 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 3:54 [PATCH v2 0/2] iio: add driver for Bosch BMA400 accelerometer Dan Robertson
2019-10-12 3:54 ` [PATCH v2 1/2] dt-bindings: iio: accel: bma400: add bindings Dan Robertson
2019-10-12 9:31 ` Jonathan Cameron
2019-10-12 3:54 ` [PATCH v2 2/2] iio: (bma400) add driver for the BMA400 Dan Robertson
2019-10-12 6:11 ` Randy Dunlap
2019-10-12 7:39 ` Andy Shevchenko
2019-10-12 9:29 ` Jonathan Cameron
2019-10-12 9:40 ` Jonathan Cameron
2019-10-12 15:35 ` Dan Robertson
2019-10-12 16:33 ` Jonathan Cameron
2019-10-12 16:38 ` Dan Robertson
2019-10-14 16:35 ` kbuild test robot
2019-10-15 13:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeyB2rZXXF34cUKp2iBfJMeN3fw8SfBMW=13sZY3z2DNA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).