From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Eugene Zaikonnikov <ez@norphonic.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
development@norphonic.com, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v9 1/2] iio: humidity: Add TI HDC20x0 support
Date: Mon, 3 Aug 2020 19:37:11 +0300 [thread overview]
Message-ID: <CAHp75VfVjGEbGxuG8xoHY56FTpZNkRxLAgAUswEbRgraKd6HQQ@mail.gmail.com> (raw)
In-Reply-To: <867dufdc2a.fsf@norphonic.com>
On Mon, Aug 3, 2020 at 5:44 PM Eugene Zaikonnikov <ez@norphonic.com> wrote:
> Sorry for the attachments, it was an accident.
I hope the next version will be sent properly.
> > On Fri, Jul 10, 2020 at 2:54 PM Eugene Zaikonnikov <ez@norphonic.com> wrote:
>
> [...]
>
> > 8. It's one line
> > ret = i2c_smbus_write_byte_data(client,
> > HDC2010_REG_MEASUREMENT_CONF, tmp);
> >
> > Ditto:
> > dev_warn(&client->dev, "Unable to restore default AMM\n");
> >
> Must be misunderstanding something, as neither of these fits 80 column
> fill if made into one line. Found also couple other places I need in
> fact to wrap down to 80.
For how many? And since it's a new driver you may use 100.
Besides that there is no limitation for the messages for a long time
(see dev_warn() example above).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-08-03 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 11:53 [PATCH v9 1/2] iio: humidity: Add TI HDC20x0 support Eugene Zaikonnikov
2020-07-10 12:20 ` [PATCH v9 2/2] dt-bindings: " Eugene Zaikonnikov
2020-07-12 10:59 ` Jonathan Cameron
2020-07-13 15:38 ` Rob Herring
2020-07-11 15:16 ` [PATCH v9 1/2] " Andy Shevchenko
2020-07-11 15:27 ` Andy Shevchenko
2020-07-12 10:54 ` Jonathan Cameron
2020-08-04 10:23 ` Eugene Zaikonnikov
2020-08-06 18:46 ` Jonathan Cameron
2020-08-07 7:28 ` Eugene Zaikonnikov
2020-08-03 14:43 ` Eugene Zaikonnikov
2020-08-03 16:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfVjGEbGxuG8xoHY56FTpZNkRxLAgAUswEbRgraKd6HQQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=development@norphonic.com \
--cc=ez@norphonic.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).