From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: saravanan sekar <sravanhome@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Sebastian Reichel <sre@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger
Date: Thu, 30 Apr 2020 14:07:59 +0300 [thread overview]
Message-ID: <CAHp75Vf_PUQdcOVdao0KUjiLapicMOFHK6f5+gf-bi-k6hVgkA@mail.gmail.com> (raw)
In-Reply-To: <4585179d-826b-6240-38a2-18fe757bc810@gmail.com>
On Thu, Apr 30, 2020 at 1:39 PM saravanan sekar <sravanhome@gmail.com> wrote:
> On 27/04/20 11:30 am, saravanan sekar wrote:
> > On 27/04/20 10:51 am, Lee Jones wrote:
> >> On Fri, 24 Apr 2020, saravanan sekar wrote:
> >>> On 24/04/20 12:53 pm, Lee Jones wrote:
> >>>> On Fri, 24 Apr 2020, saravanan sekar wrote:
> >>>>> On 24/04/20 11:37 am, Lee Jones wrote:
> >>>>>> On Fri, 24 Apr 2020, saravanan sekar wrote:
...
> >>>>>> Then how about using 'simple-mfd' and 'syscon'?
> >>>>>>
> >>>>>> Then you can omit this driver completely.
> >>>>> The exception is to support for non device tree platform as well,
> >>>>> but I have
> >>>>> tested only for ARM device tree platform.
> >>>> Is that a reality though?
> >>>>
> >>>> How else do you see this realistically being registered?
> >>>>
> >>> I understand that acpi related device table are not covered here,
> >>> well I
> >>> don't have to platform to test so.
> >>> If you ask me to cover acpi related table, I can do but hard to test.
> >> I don't know of any reasons why syscon can't be used by ACPI.
> >>
> >> Please try to solve this issue using 'simple-mfd' and 'syscon'.
> > Well the simple-mfd and syscon topic recommended by you when Device
> > tree alone is used.
> > I wounder still I receive review/improvements comments for this mfd
> > patch and also another
> > to omit this driver using simple-mfd (rework the series).
> > Confused, not sure which is valid and will be accepted at the end.
>
> I had look into syscon, as far my understanding syscon is supported only
> for memory mapped IO. MP2629
> device is over I2C bus, could you share your thought about syscon for
> this device?
My understanding too, but I didn't dug into it.
Something like general regmap support is missing (or I am missing the
way how to pass it to syscon).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-30 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:20 [PATCH v9 0/6] Add battery charger driver support for MP2629 Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 1/6] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-04-15 19:07 ` Peter Meerwald-Stadler
2020-04-16 20:44 ` Rob Herring
2020-04-15 16:20 ` [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-04-24 7:18 ` Lee Jones
2020-04-24 7:26 ` saravanan sekar
2020-04-24 9:37 ` Lee Jones
2020-04-24 10:23 ` saravanan sekar
2020-04-24 10:53 ` Lee Jones
2020-04-24 11:04 ` saravanan sekar
2020-04-27 8:51 ` Lee Jones
2020-04-27 9:30 ` saravanan sekar
2020-04-30 10:39 ` saravanan sekar
2020-04-30 11:07 ` Andy Shevchenko [this message]
2020-04-27 7:26 ` Lee Jones
2020-04-15 16:20 ` [PATCH v9 3/6] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 4/6] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-04-15 19:32 ` Peter Meerwald-Stadler
2020-04-15 16:20 ` [PATCH v9 5/6] power: supply: mp2629: Add impedance compenstation config Saravanan Sekar
2020-04-15 19:33 ` Peter Meerwald-Stadler
2020-04-15 16:20 ` [PATCH v9 6/6] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
2020-04-15 16:40 ` [PATCH v9 0/6] Add battery charger driver support for MP2629 Andy Shevchenko
2020-04-15 16:53 ` saravanan sekar
2020-04-15 17:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf_PUQdcOVdao0KUjiLapicMOFHK6f5+gf-bi-k6hVgkA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).