From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Kevin Tsai <ktsai@capellamicro.com>,
Jonathan Cameron <jic23@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 4/8] iio: light: cm32181: Change reg_init to use a bitmap of which registers to init
Date: Sun, 26 Apr 2020 20:44:46 +0300 [thread overview]
Message-ID: <CAHp75VfqBGyN5KZW1fZtvCU6GgReDLqcPkWxF4Ovku9n9vdjPA@mail.gmail.com> (raw)
In-Reply-To: <20200426110256.218186-4-hdegoede@redhat.com>
On Sun, Apr 26, 2020 at 2:03 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> This is a preparation patch for reading some ACPI tables which give
> init values for multiple registers.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/iio/light/cm32181.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index e8be20d3902c..e31c1005b03d 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -26,7 +26,7 @@
> #define CM32181_REG_ADDR_ID 0x07
>
> /* Number of Configurable Registers */
> -#define CM32181_CONF_REG_NUM 0x01
> +#define CM32181_CONF_REG_NUM 4
>
> /* CMD register */
> #define CM32181_CMD_ALS_DISABLE BIT(0)
> @@ -53,10 +53,6 @@
>
> #define SMBUS_ALERT_RESPONSE_ADDRESS 0x0c
>
> -static const u8 cm32181_reg[CM32181_CONF_REG_NUM] = {
> - CM32181_REG_ADDR_CMD,
> -};
> -
> /* CM3218 Family */
> static const int cm3218_als_it_bits[] = { 0, 1, 2, 3 };
> static const int cm3218_als_it_values[] = { 100000, 200000, 400000, 800000 };
> @@ -71,6 +67,7 @@ struct cm32181_chip {
> struct i2c_client *client;
> struct mutex lock;
> u16 conf_regs[CM32181_CONF_REG_NUM];
> + int init_regs_bitmap;
unsigned long
> int calibscale;
> int num_als_it;
> const int *als_it_bits;
> @@ -117,14 +114,17 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
> /* Default Values */
> cm32181->conf_regs[CM32181_REG_ADDR_CMD] =
> CM32181_CMD_ALS_IT_DEFAULT | CM32181_CMD_ALS_SM_DEFAULT;
> + cm32181->init_regs_bitmap = BIT(CM32181_REG_ADDR_CMD);
> cm32181->calibscale = CM32181_CALIBSCALE_DEFAULT;
>
> /* Initialize registers*/
> for (i = 0; i < CM32181_CONF_REG_NUM; i++) {
> - ret = i2c_smbus_write_word_data(client, cm32181_reg[i],
> - cm32181->conf_regs[i]);
> - if (ret < 0)
> - return ret;
> + if (cm32181->init_regs_bitmap & BIT(i)) {
for_each_set_bit()
> + ret = i2c_smbus_write_word_data(client, i,
> + cm32181->conf_regs[i]);
> + if (ret < 0)
> + return ret;
> + }
> }
>
> return 0;
> --
> 2.26.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-26 17:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 11:02 [PATCH 1/8] iio: light: cm32181: Add some extra register defines Hans de Goede
2020-04-26 11:02 ` [PATCH 2/8] iio: light: cm32181: Add support for the CM3218 Hans de Goede
2020-04-26 11:02 ` [PATCH 3/8] iio: light: cm32181: Handle ACPI instantiating a cm32181 client on the SMBus ARA Hans de Goede
2020-04-26 17:43 ` Andy Shevchenko
2020-04-26 11:02 ` [PATCH 4/8] iio: light: cm32181: Change reg_init to use a bitmap of which registers to init Hans de Goede
2020-04-26 17:44 ` Andy Shevchenko [this message]
2020-04-26 11:02 ` [PATCH 5/8] iio: light: cm32181: Use units of 1/100000th for calibscale and lux_per_bit Hans de Goede
2020-04-26 11:02 ` [PATCH 6/8] iio: light: cm32181: Make lux_per_bit and lux_per_bit_base_it runtime settings Hans de Goede
2020-04-26 11:02 ` [PATCH 7/8] iio: light: cm32181: Add support for parsing CPM0 and CPM1 ACPI tables Hans de Goede
2020-04-26 17:50 ` Andy Shevchenko
2020-04-27 15:31 ` Hans de Goede
2020-04-26 11:02 ` [PATCH 8/8] iio: light: cm32181: Fix integartion time typo Hans de Goede
2020-04-26 17:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfqBGyN5KZW1fZtvCU6GgReDLqcPkWxF4Ovku9n9vdjPA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).