From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
notify@kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>
Subject: Re: [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema
Date: Tue, 3 Sep 2019 09:58:21 +0200 [thread overview]
Message-ID: <CAJKOXPc0SY_8BHMsWLN=1M3VQh41+bdBiH21L4KQPA+iLPYy+A@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJybT41cEqiTriLMywUQj1BtAG_9muJ4=84OkF23y53CA@mail.gmail.com>
On Mon, 26 Aug 2019 at 13:54, Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Aug 23, 2019 at 9:54 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema
> > format using json-schema.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../devicetree/bindings/arm/samsung/pmu.txt | 72 --------------
> > .../devicetree/bindings/arm/samsung/pmu.yaml | 93 +++++++++++++++++++
> > 2 files changed, 93 insertions(+), 72 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt
> > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > new file mode 100644
> > index 000000000000..818c6f3488ef
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > @@ -0,0 +1,93 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung Exynos SoC series Power Management Unit (PMU)
> > +
> > +maintainers:
> > + - Krzysztof Kozlowski <krzk@kernel.org>
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - samsung,exynos3250-pmu
> > + - samsung,exynos4210-pmu
> > + - samsung,exynos4412-pmu
> > + - samsung,exynos5250-pmu
> > + - samsung,exynos5260-pmu
> > + - samsung,exynos5410-pmu
> > + - samsung,exynos5420-pmu
> > + - samsung,exynos5433-pmu
> > + - samsung,exynos7-pmu
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > + clock-names:
> > + description:
> > + list of clock names for particular CLKOUT mux inputs
> > + # TODO: what is the maximum number of elements (mux inputs)?
> > + minItems: 1
> > + maxItems: 32
> > + items:
> > + - enum:
>
> This isn't correct as you are only defining possible names for the
> first item. Drop the '-' (making items a schema instead of a list) and
> then it applies to all. However, doing that will cause a meta-schema
> error which I need to fix to allow. Or if there's a small set of
> possibilities of number of inputs, you can list them under a 'oneOf'
> list.
Mhmm, I cannot test it or I have an error in the schema. if I
understand correctly, this would be:
clock-names:
description:
List of clock names for particular CLKOUT mux inputs
minItems: 1
maxItems: 16
items:
clkout0
clkout1
clkout2
clkout3
clkout4
clkout5
clkout6
clkout7
clkout8
clkout9
clkout10
clkout11
clkout12
clkout13
clkout14
clkout15
clkout16
Now it produces the error "ignoring, error in schema 'items'" but
maybe it is expected with current meta-schema?
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-09-03 7:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 14:53 [RFC 1/9] dt-bindings: arm: samsung: Convert Samsung board/soc bindings to json-schema Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 2/9] dt-bindings: arm: samsung: Document missing S5Pv210 boards bindings Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 3/9] dt-bindings: arm: samsung: Document missing Exynos7 " Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 4/9] dt-bindings: arm: samsung: Convert Exynos Chipid bindings to json-schema Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU " Krzysztof Kozlowski
2019-08-26 11:54 ` Rob Herring
2019-09-03 7:58 ` Krzysztof Kozlowski [this message]
2019-09-03 8:25 ` Rob Herring
2019-09-03 11:03 ` Krzysztof Kozlowski
2019-09-06 15:48 ` Rob Herring
2019-09-07 9:22 ` Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 6/9] dt-bindings: arm: samsung: Convert Exynos System Registers " Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 7/9] dt-bindings: rtc: s3c: Convert S3C/Exynos RTC " Krzysztof Kozlowski
2019-08-26 12:06 ` Rob Herring
2019-09-02 12:47 ` Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 8/9] dt-bindings: iio: adc: exynos: Convert Exynos ADC " Krzysztof Kozlowski
2019-08-23 14:53 ` [RFC 9/9] ARM: dts: exynos: Remove not accurate secondary ADC compatible Krzysztof Kozlowski
2019-08-26 11:37 ` [RFC 1/9] dt-bindings: arm: samsung: Convert Samsung board/soc bindings to json-schema Rob Herring
2019-09-02 7:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPc0SY_8BHMsWLN=1M3VQh41+bdBiH21L4KQPA+iLPYy+A@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=notify@kernel.org \
--cc=olof@lixom.net \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).