From: Vaishnav M A <vaishnav@beagleboard.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Matt Ranostay" <matt.ranostay@konsulko.com>,
linux-iio <linux-iio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jason Kridner" <jkridner@beagleboard.org>,
"Drew Fustini" <drew@beagleboard.org>,
"Robert Nelson" <robertcnelson@beagleboard.org>,
"Ivan Rajković" <rajkovic@mikroe.com>
Subject: Re: [PATCH v3] iio: light: vcnl4035 add i2c_device_id
Date: Mon, 19 Oct 2020 01:31:39 +0530 [thread overview]
Message-ID: <CALudOK5Hy3cU6W+yWAgpqxP-27K2MXiwSwR1x3z=mJjq3y3K8w@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vch2jPwZm8gVC6zRs6k=BR23Mb15Q4R4VbpMZ5FwshNLQ@mail.gmail.com>
On Sun, Oct 18, 2020 at 11:59 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Oct 18, 2020 at 6:47 PM Vaishnav M A <vaishnav@beagleboard.org> wrote:
> >
> > Add i2c_device_id table for the vl53l0x-i2c driver,
> > helps in device instantiation using i2c_new_client_device
>
> In all your patches please refer to the functions like function().
> For example, here is i2c_new_client_device().
>
> > or from userspace in cases where device-tree based description
> > is not possible now (Example: device on a gbphy i2c adapter
> > created by greybus)
>
> Don't forget proper English punctuation, like periods at the end of sentences.
>
> --
> With Best Regards,
> Andy Shevchenko
Thank you Andy for your review, I have updated v4 patch with your suggestions,
https://lore.kernel.org/patchwork/patch/1322219/ (sorry about the
incorrect driver
name in the first-line of the commit message in the v3 version). This is
also fixed in the v4 submission.
Thanks,
Vaishnav
prev parent reply other threads:[~2020-10-18 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 15:04 [PATCH v3] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
2020-10-18 18:28 ` Andy Shevchenko
2020-10-18 20:01 ` Vaishnav M A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALudOK5Hy3cU6W+yWAgpqxP-27K2MXiwSwR1x3z=mJjq3y3K8w@mail.gmail.com' \
--to=vaishnav@beagleboard.org \
--cc=alexandru.ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=drew@beagleboard.org \
--cc=jic23@kernel.org \
--cc=jkridner@beagleboard.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=rajkovic@mikroe.com \
--cc=robertcnelson@beagleboard.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).