From: Fabio Estevam <festevam@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-iio@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC
Date: Thu, 23 Sep 2021 19:12:20 -0300 [thread overview]
Message-ID: <CAOMZO5CDgFHVyVAF6a5WKwsAE60t5zBBu-T+hScUO6WsmTQUvQ@mail.gmail.com> (raw)
In-Reply-To: <20210921052821.91-2-caihuoqing@baidu.com>
Hi Cai,
On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> +error_iio_device_register:
> + clk_disable_unprepare(adc->ipg_clk);
> +error_adc_ipg_clk_enable:
> + clk_disable_unprepare(adc->clk);
> +error_adc_clk_enable:
> + regulator_disable(adc->vref);
Please rename these labels to indicate the action that will be performed.
Something like this:
error_ipg_clk_disable:
clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
clk_disable_unprepare(adc->clk);
error_regulator_disable:
regulator_disable(adc->vref);
next prev parent reply other threads:[~2021-09-23 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 5:28 [PATCH v5 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC Cai Huoqing
2021-09-21 5:28 ` [PATCH v5 1/3] " Cai Huoqing
2021-09-23 22:12 ` Fabio Estevam [this message]
2021-09-21 5:28 ` [PATCH v5 2/3] iio: imx8qxp-adc: dt-bindings: iio: adc: Add binding documentation " Cai Huoqing
2021-09-23 22:04 ` Rob Herring
2021-09-21 5:28 ` [PATCH v5 3/3] MAINTAINERS: Add the driver info of the NXP IMX8QXP Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5CDgFHVyVAF6a5WKwsAE60t5zBBu-T+hScUO6WsmTQUvQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).