From: Fabien Parent <fparent@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-iio@vger.kernel.org, chun-hung.wu@mediatek.com,
alexandru.ardelean@analog.com, pmeerw@pmeerw.net,
lars@metafoo.de, knaack.h@gmx.de
Subject: Re: [PATCH] iio: adc: mediatek: fix unset field
Date: Sun, 18 Oct 2020 19:16:49 +0200 [thread overview]
Message-ID: <CAOwMV_xxfJqUieArCE-dDS-fy65vGQhcbMwsGqrTFs4-XA0p2Q@mail.gmail.com> (raw)
In-Reply-To: <20201018110738.36e3de38@archlinux>
Hi Jonathan,
On Sun, Oct 18, 2020 at 12:07 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 13 Oct 2020 17:37:12 +0200
> Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> > On 12/10/2020 21:46, Fabien Parent wrote:
> > > dev_comp field is used in a couple of places but it is never set. This
> > > results in kernel oops when dereferencing a NULL pointer. Set the
> > > `dev_comp` field correctly in the probe function.
> > >
> > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> > >
> > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> >
> > Ouch.
> >
> > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >
> > > ---
> > > drivers/iio/adc/mt6577_auxadc.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> > > index ac415cb089cd..7bd48377cd79 100644
> > > --- a/drivers/iio/adc/mt6577_auxadc.c
> > > +++ b/drivers/iio/adc/mt6577_auxadc.c
> > > @@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
> > > goto err_disable_clk;
> > > }
> > >
> > > + adc_dev->dev_comp = of_device_get_match_data(&pdev->dev);
> > > +
>
> Could we switch this to device_get_match_data(&pdev->dev)?
>
> Whilst is unlikely this driver will used in a platform using ACPI, there
> is nothing inside the driver itself preventing this (which is good as no
> reason to do so!) My main motivation for this is to reduce the chances
> of cut and paste of the of_* functions in future driver.
>
> Also switch the headers to linux/property.h and linux/mod_devicetable.h
> to more tightly reflect what we are using in the driver.
I applied these changes in v2.
>
> Thanks,
>
> Jonathan
>
> > > mutex_init(&adc_dev->lock);
> > >
> > > mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,
> > >
>
prev parent reply other threads:[~2020-10-18 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 19:46 [PATCH] iio: adc: mediatek: fix unset field Fabien Parent
2020-10-13 15:37 ` Matthias Brugger
2020-10-18 10:07 ` Jonathan Cameron
2020-10-18 17:16 ` Fabien Parent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOwMV_xxfJqUieArCE-dDS-fy65vGQhcbMwsGqrTFs4-XA0p2Q@mail.gmail.com \
--to=fparent@baylibre.com \
--cc=alexandru.ardelean@analog.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).