From: Anson Huang <anson.huang@nxp.com>
To: Phil Reid <preid@electromag.com.au>,
"jic23@kernel.org" <jic23@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support
Date: Tue, 11 Dec 2018 03:43:46 +0000 [thread overview]
Message-ID: <DB3PR0402MB39161ED492C863BB48D48E2FF5A60@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <d07b5970-5825-2ea6-9e27-538386927923@electromag.com.au>
Hi, Phil
Best Regards!
Anson Huang
> -----Original Message-----
> From: Phil Reid [mailto:preid@electromag.com.au]
> Sent: 2018年12月11日 11:36
> To: Anson Huang <anson.huang@nxp.com>; jic23@kernel.org;
> knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net;
> robh+dt@kernel.org; mark.rutland@arm.com; linux-iio@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> festevam@gmail.com
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda
> regulator operation support
>
> On 11/12/2018 11:24 am, Anson Huang wrote:
> > The light sensor's power supply could be controlled by regulator on
> > some platforms, such as i.MX6Q-SABRESD board, the light sensor
> > isl29023's power supply is controlled by a GPIO fixed regulator, need
> > to make sure the regulator is enabled before any operation of sensor,
> > this patch adds optional vdd/vdda regulator operation support.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > ChangeLog since V3:
> > - improve the error handling of devm_regulator_get_optional;
> > - make sure regulators are disabled in error path.
> > ---
> > drivers/iio/light/isl29018.c | 83
> ++++++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 80 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/light/isl29018.c
> > b/drivers/iio/light/isl29018.c index b45400f..a21652b 100644
> > --- a/drivers/iio/light/isl29018.c
> > +++ b/drivers/iio/light/isl29018.c
> > @@ -23,6 +23,7 @@
> > #include <linux/mutex.h>
> > #include <linux/delay.h>
> > #include <linux/regmap.h>
> > +#include <linux/regulator/consumer.h>
> > #include <linux/slab.h>
> > #include <linux/iio/iio.h>
> > #include <linux/iio/sysfs.h>
> > @@ -95,6 +96,8 @@ struct isl29018_chip {
> > struct isl29018_scale scale;
> > int prox_scheme;
> > bool suspended;
> > + struct regulator *vdd_reg;
> > + struct regulator *vdda_reg;
> > };
> >
> > static int isl29018_set_integration_time(struct isl29018_chip *chip,
> > @@ -735,6 +738,34 @@ static int isl29018_probe(struct i2c_client
> > *client,
> >
> > mutex_init(&chip->lock);
> >
> > + chip->vdd_reg = devm_regulator_get_optional(&client->dev, "vdd");
> > + if (!IS_ERR(chip->vdd_reg)) {
> > + err = regulator_enable(chip->vdd_reg);
> > + if (err) {
> > + dev_err(&client->dev, "failed to enable VDD regulator\n");
> > + return err;
> > + }
> > + } else {
> > + err = PTR_ERR(chip->vdd_reg);
> > + if (err != -ENODEV)
> > + return err;
> > + }
> > +
> > + chip->vdda_reg = devm_regulator_get_optional(&client->dev, "vdda");
> > + if (!IS_ERR(chip->vdda_reg)) {
> > + err = regulator_enable(chip->vdda_reg);
> > + if (err) {
> > + dev_err(&client->dev, "failed to enable VDDA regulator\n");
> > + if (!IS_ERR(chip->vdd_reg))
> > + regulator_disable(chip->vdd_reg);
> > + return err;
> > + }
> > + } else {
> > + err = PTR_ERR(chip->vdda_reg);
> > + if (err != -ENODEV)
> > + return err;
> maybe goto disable_regulators; to disable vdd.
Agree, I will use " goto disable_regulators;" in both here and upper regulator enable fail case.
Please help review V5, thanks.
Anson
>
> > + }
> > +
> > chip->type = dev_id;
> > chip->calibscale = 1;
> > chip->ucalibscale = 0;
> > @@ -747,12 +778,12 @@ static int isl29018_probe(struct i2c_client *client,
> > if (IS_ERR(chip->regmap)) {
> > err = PTR_ERR(chip->regmap);
> > dev_err(&client->dev, "regmap initialization fails: %d\n", err);
> > - return err;
> > + goto disable_regulators;
> > }
> >
> > err = isl29018_chip_init(chip);
> > if (err)
> > - return err;
> > + goto disable_regulators;
> >
> > indio_dev->info = isl29018_chip_info_tbl[dev_id].indio_info;
> > indio_dev->channels = isl29018_chip_info_tbl[dev_id].channels;
> > @@ -761,13 +792,24 @@ static int isl29018_probe(struct i2c_client *client,
> > indio_dev->dev.parent = &client->dev;
> > indio_dev->modes = INDIO_DIRECT_MODE;
> >
> > - return devm_iio_device_register(&client->dev, indio_dev);
> > + err = devm_iio_device_register(&client->dev, indio_dev);
> > + if (!err)
> > + return 0;
> > +
> > +disable_regulators:
> > + if (!IS_ERR(chip->vdd_reg))
> > + regulator_disable(chip->vdd_reg);
> > + if (!IS_ERR(chip->vdda_reg))
> > + regulator_disable(chip->vdda_reg);
> > +
> > + return err;
> > }
> >
> [snip]
>
> --
> Regards
> Phil
next prev parent reply other threads:[~2018-12-11 3:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 3:24 [PATCH V4 1/2] dt-bindings: iio: light: isl29018: update power supply name Anson Huang
2018-12-11 3:24 ` [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support Anson Huang
2018-12-11 3:36 ` Phil Reid
2018-12-11 3:43 ` Anson Huang [this message]
2018-12-11 3:56 ` Phil Reid
2018-12-11 4:29 ` Anson Huang
2018-12-11 5:02 ` Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB39161ED492C863BB48D48E2FF5A60@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).