Re: [PATCH v2 12/13] iio: imu: inv_mpu6050: use runtime pm with autosuspend

[Jean-Baptiste Maneyrol <JManeyrol@invensense.com>]

Hello Dmitry,

that's right, thanks for finding it.

Hopefully this will not prevent system suspend since we are not checking on the return value.

System suspend/resume callbacks need to be reworked to work correctly with pm_runtime.
I will send a fix patch when it is ready.

Thanks,
JB



From: Dmitry Osipenko <digetx@gmail.com>

Sent: Tuesday, March 24, 2020 22:24

To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>; jic23@kernel.org <jic23@kernel.org>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>

Subject: Re: [PATCH v2 12/13] iio: imu: inv_mpu6050: use runtime pm with autosuspend

 


 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.



19.02.2020 17:39, Jean-Baptiste Maneyrol пишет:

> Use runtime power management for handling chip power and

> sensor engines on/off. Simplifies things a lot since pm

> runtime already has reference counter.

> Usage of autosuspend reduces the number of power on/off. This

> makes polling interface now usable to get data at low

> frequency.

> 

> Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>

> ---

>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c    | 267 ++++++++++++------

>  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h     |   5 +-

>  drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c |  33 ++-

>  3 files changed, 194 insertions(+), 111 deletions(-)



Hello,



This patch introduces a system suspend-resume regressing, I'm seeing the

following on entering into suspend:



 vdd_gen1v8: Underflow of regulator enable count

 inv-mpu6050-i2c 1-0068: Failed to disable vddio regulator: -22



Apparently RPM disables the regulator and then it's erroneously disabled

second time on suspend. Please fix it, thanks in advance.