From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Kent Gustavsson <kent@minoris.se>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/9] iio: adc: mcp3911: use correct formula for AD conversion
Date: Sun, 17 Jul 2022 15:58:12 +0200 [thread overview]
Message-ID: <YtQVdNdMVDyOSEW8@gmail.com> (raw)
In-Reply-To: <20220716181837.4b0b8870@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
Hi,
On Sat, Jul 16, 2022 at 06:18:37PM +0100, Jonathan Cameron wrote:
> On Mon, 4 Jul 2022 19:21:10 +0200
> Marcus Folkesson <marcus.folkesson@gmail.com> wrote:
>
> > The ADC conversion is actually not rail-to-rail but with a factor 1.5.
> > Make use of this factor when calculating actual voltage.
> >
> > Fixes: 3a89b289df5d ("iio: adc: add support for mcp3911")
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > Acked-by: Jonathan Cameron <jic23@kernel.org>
> ? I doubt I gave a tag (mostly because I don't give tags to patches
> I'll pick up and give a SoB on.
>
> Note that tags have to be given explicitly in full form before you can
> add them to a patch. If in doubt (people often given handwavey responses)
> then ask people to give an explicit tag.
Sorry for that. I will remove the tag.
I interpreted your "Otherwise looks good to me." as an acked-by.
I will only go for explicit tags forward.
Thanks,
Marcus Folkesson
>
> Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-17 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 17:21 [PATCH v3 0/9] Improve MCP3911 driver Marcus Folkesson
2022-07-04 17:21 ` [PATCH v3 1/9] iio: adc: mcp3911: make use of the sign bit Marcus Folkesson
2022-07-04 17:21 ` [PATCH v3 2/9] iio: adc: mcp3911: correct "microchip,device-addr" property Marcus Folkesson
2022-07-04 17:21 ` [PATCH v3 3/9] iio: adc: mcp3911: use correct formula for AD conversion Marcus Folkesson
2022-07-16 17:18 ` Jonathan Cameron
2022-07-17 13:58 ` Marcus Folkesson [this message]
2022-07-04 17:21 ` [PATCH v3 4/9] iio: adc: mcp3911: use resource-managed version of iio_device_register Marcus Folkesson
2022-07-16 17:22 ` Jonathan Cameron
2022-07-04 17:21 ` [PATCH v3 5/9] iio: adc: mcp3911: add support for buffers Marcus Folkesson
2022-07-04 21:56 ` Andy Shevchenko
2022-07-04 17:21 ` [PATCH v3 6/9] iio: adc: mcp3911: add support for interrupts Marcus Folkesson
2022-07-04 21:57 ` Andy Shevchenko
2022-07-04 17:21 ` [PATCH v3 7/9] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry Marcus Folkesson
2022-07-04 17:21 ` [PATCH v3 8/9] iio: adc: mcp3911: add support for oversampling ratio Marcus Folkesson
2022-07-04 21:58 ` Andy Shevchenko
2022-07-04 17:21 ` [PATCH v3 9/9] iio: adc: mcp3911: add support to set PGA Marcus Folkesson
2022-07-04 22:02 ` Andy Shevchenko
2022-07-04 22:03 ` [PATCH v3 0/9] Improve MCP3911 driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtQVdNdMVDyOSEW8@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).