linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Frey <dpfrey@gmail.com>
To: linux-iio <linux-iio@vger.kernel.org>
Subject: Adding "fault count" support to opt3001
Date: Fri, 27 Sep 2019 10:08:19 -0700	[thread overview]
Message-ID: <a3335ddc-6961-79fa-308d-868e156960d1@gmail.com> (raw)

Hi,

The TI opt3001 light sensor has a fault count field in its configuration
register.  See http://www.ti.com/lit/ds/symlink/opt3001.pdf on page 23.
Basically, this field controls how many samples must be above the high
threshold or below the low threshold in order to trigger the interrupt.
Currently the driver initializes this field to 0 meaning that one fault
will trigger an interrupt.

0b00 -> 1
0b01 -> 2
0b10 -> 4
0b11 -> 8

The driver has an IIO event which allows for the high/low threshold to
be set and enabled/disabled.  I would like to add the ability to specify
the fault count as well and I'm wondering how this should be done.  I
believe it should be done by adding a .mask_shared_by_type =
BIT(IIO_EV_INFO_???) definition within the struct iio_event_spec, but
I'm not sure if any of the existing IIO_EV_INFO_ values are appropriate.
 The only one that might be appropriate is IIO_EV_INFO_HYSTERESIS.

Am I going about this the right way?
Is IIO_EV_INFO_HYSTERESIS appropriate?
Should a new enum value be defined?

Thanks,
David

             reply	other threads:[~2019-09-27 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 17:08 David Frey [this message]
2019-10-06  9:40 ` Adding "fault count" support to opt3001 Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3335ddc-6961-79fa-308d-868e156960d1@gmail.com \
    --to=dpfrey@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).