From: Martin Kelly <martin@martingkelly.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/5] iio:bmi160: add drdy interrupt support
Date: Mon, 21 Jan 2019 18:06:32 -0800 [thread overview]
Message-ID: <a88c6993-280b-2e44-e861-6883f67ed20e@martingkelly.com> (raw)
In-Reply-To: <20190119171704.4356c763@archlinux>
On 1/19/19 9:17 AM, Jonathan Cameron wrote:
> On Sun, 13 Jan 2019 19:56:18 -0800
> Martin Kelly <martin@martingkelly.com> wrote:
>
>> From: Martin Kelly <martin@martingkelly.com>
>>
>> Add interrupt support for the data ready signal on the BMI160, which fires
>> an interrupt whenever new accelerometer/gyroscope data is ready to read.
>
> Various minor comments inline. Mostly fine, but one big 'oddity'.
>
> I think we only ever request 1 irq, but we have support in here for
> configuring the chip to generate two at the same time. Doesn't make
> much sense as it stands... Am I missing something?
>
> Jonathan
>
Yeah, I initially wrote it not allowing for a "BOTH" mapping but added
it afterwards in order to support what the hardware allows. However,
thinking about it more, the hardware allows this so that you can map
different types of interrupts onto the two pins. So, I agree with you
that with just a DRDY interrupt, there's no reason for this mapping, so
I've dropped it.
Thanks for the other comments; I have made all the changes you suggested
and sent a v2. I also added a cleanup patch in the v2 to change the
other invocations of "if (ret < 0)" to "if (ret)", as there were a
number of them in the driver prior to this change.
next prev parent reply other threads:[~2019-01-22 2:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 3:56 [PATCH 0/5] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-14 3:56 ` [PATCH 1/5] iio:bmi160: add SPDX identifiers Martin Kelly
2019-01-19 17:03 ` Jonathan Cameron
2019-01-14 3:56 ` [PATCH 2/5] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-19 17:17 ` Jonathan Cameron
2019-01-22 2:06 ` Martin Kelly [this message]
2019-01-14 3:56 ` [PATCH 3/5] dt-bindings: fix incorrect bmi160 IRQ note Martin Kelly
2019-01-14 3:56 ` [PATCH 4/5] dt-bindings:bmi160: add "BOTH" int pin type Martin Kelly
2019-01-19 17:24 ` Jonathan Cameron
2019-01-14 3:56 ` [PATCH 5/5] iio:bmi160:snap timestamp closer to event Martin Kelly
2019-01-19 17:29 ` Jonathan Cameron
2019-01-15 2:13 ` [PATCH 0/5] iio:bmi160: add drdy interrupt support Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a88c6993-280b-2e44-e861-6883f67ed20e@martingkelly.com \
--to=martin@martingkelly.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).