From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Fabien Dessenne <fabien.dessenne@st.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-iio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe
Date: Wed, 24 Apr 2019 14:55:28 +0200 [thread overview]
Message-ID: <b46f9525-53c0-d874-c88f-c6e351736b04@st.com> (raw)
In-Reply-To: <1556110286-1526-3-git-send-email-fabien.dessenne@st.com>
On 4/24/19 2:51 PM, Fabien Dessenne wrote:
> During probe, check the devm_ioremap_resource() error value.
> Also return the devm_clk_get() error value instead of -EINVAL.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
Hi Fabien,
Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Thanks,
Fabrice
> drivers/iio/adc/stm32-dfsdm-core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 0a4d374..26e2011 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -233,6 +233,8 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> }
> priv->dfsdm.phys_base = res->start;
> priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(priv->dfsdm.base))
> + return PTR_ERR(priv->dfsdm.base);
>
> /*
> * "dfsdm" clock is mandatory for DFSDM peripheral clocking.
> @@ -242,8 +244,10 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev,
> */
> priv->clk = devm_clk_get(&pdev->dev, "dfsdm");
> if (IS_ERR(priv->clk)) {
> - dev_err(&pdev->dev, "No stm32_dfsdm_clk clock found\n");
> - return -EINVAL;
> + ret = PTR_ERR(priv->clk);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to get clock (%d)\n", ret);
> + return ret;
> }
>
> priv->aclk = devm_clk_get(&pdev->dev, "audio");
>
next prev parent reply other threads:[~2019-04-24 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 12:51 [PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe Fabien Dessenne
2019-04-24 12:51 ` [PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case Fabien Dessenne
2019-04-24 12:55 ` Fabrice Gasnier
2019-04-27 13:08 ` Jonathan Cameron
2019-04-24 12:51 ` [PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne
2019-04-24 12:55 ` Fabrice Gasnier [this message]
2019-04-27 13:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b46f9525-53c0-d874-c88f-c6e351736b04@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=fabien.dessenne@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).