From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>, Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] iio: bme680_i2c: Remove ACPI support
Date: Thu, 6 May 2021 10:29:36 +0200 [thread overview]
Message-ID: <ba228717-ef0f-1568-bf7e-3cfac454ba1f@redhat.com> (raw)
In-Reply-To: <20210506034332.752263-1-linux@roeck-us.net>
Hi,
On 5/6/21 5:43 AM, Guenter Roeck wrote:
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/chemical/bme680_i2c.c:46:36: error:
> 'bme680_acpi_match' defined but not used
>
> Apparently BME0680 is not a valid ACPI ID. Remove it and with it
> ACPI support from the bme680_i2c driver.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Instead of making bme680_acpi_match conditional,
> remove ACPI support entirely since the ACPI ID is
> not valid.
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> drivers/iio/chemical/bme680_i2c.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c
> index 29c0dfa4702b..74cf89c82c0a 100644
> --- a/drivers/iio/chemical/bme680_i2c.c
> +++ b/drivers/iio/chemical/bme680_i2c.c
> @@ -11,7 +11,6 @@
> * Note: SDO pin cannot be left floating otherwise I2C address
> * will be undefined.
> */
> -#include <linux/acpi.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/regmap.h>
> @@ -42,12 +41,6 @@ static const struct i2c_device_id bme680_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, bme680_i2c_id);
>
> -static const struct acpi_device_id bme680_acpi_match[] = {
> - {"BME0680", 0},
> - {},
> -};
> -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
> -
> static const struct of_device_id bme680_of_i2c_match[] = {
> { .compatible = "bosch,bme680", },
> {},
> @@ -57,7 +50,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_i2c_match);
> static struct i2c_driver bme680_i2c_driver = {
> .driver = {
> .name = "bme680_i2c",
> - .acpi_match_table = ACPI_PTR(bme680_acpi_match),
> .of_match_table = bme680_of_i2c_match,
> },
> .probe = bme680_i2c_probe,
>
next prev parent reply other threads:[~2021-05-06 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 3:43 [PATCH v2] iio: bme680_i2c: Remove ACPI support Guenter Roeck
2021-05-06 8:29 ` Hans de Goede [this message]
2021-05-06 9:28 ` Andy Shevchenko
2021-05-06 13:37 ` Guenter Roeck
2021-05-06 13:42 ` Hans de Goede
2021-05-06 13:50 ` Guenter Roeck
2021-05-06 14:31 ` Andy Shevchenko
2021-05-06 14:37 ` Joe Perches
2021-05-06 14:27 ` Andy Shevchenko
2021-05-07 9:31 ` Jonathan Cameron
2021-05-07 13:34 ` Guenter Roeck
2021-05-08 3:09 ` Guenter Roeck
[not found] ` <CAHp75Vfa3GT9bnimxw7EJsJyRF8HZP3PGsUNikSScuNiU4qArg@mail.gmail.com>
2021-05-08 9:41 ` Hans de Goede
2021-05-08 9:47 ` Hans de Goede
2021-05-08 15:24 ` Guenter Roeck
2021-05-08 15:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba228717-ef0f-1568-bf7e-3cfac454ba1f@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).