From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"denis.ciocca@st.com" <denis.ciocca@st.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 4/4] iio:pressure: preenable/postenable/predisable fixup for ST press buffer
Date: Tue, 30 Jul 2019 09:02:20 +0000 [thread overview]
Message-ID: <c73657b4203d8112636751413c85f525f57dcc2a.camel@analog.com> (raw)
In-Reply-To: <20190730000305.30958-5-denis.ciocca@st.com>
On Mon, 2019-07-29 at 17:03 -0700, Denis Ciocca wrote:
> [External]
>
> This patch is trying to cleanup for good the buffers operation functions.
> There is no need of using preenable, all can be done into
> postenable. Let's also use logical sequence of operations as
> already done in accel driver.
> Finally also rename the goto label using operation to perform and not
> where it fails.
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Unrelated to this patch, I was thinking that it would be a neat idea to move the `buffer_data` allocation in
`drivers/iio/common/st_sensors/st_sensors_buffer.c`
This would remove some duplication of this alloc + free in drivers.
Maybe in st_sensors_trigger_handler() something like:
if (!sdata->buffer_data) {
sdata->buffer_data = devm_kmalloc()
if (!sdata->buffer_data) {
dev_err(indio_dev->dev, "Failed to allocate buffer data\n");
goto st_sensors_get_buffer_element_error;
}
}
Using devm_kmalloc() or a similar devm_ variant would be neat, since it gets free'd when the device gets removed.
Thanks
Alex
> Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
> ---
> drivers/iio/pressure/st_pressure_buffer.c | 32 ++++++++---------------
> 1 file changed, 11 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/iio/pressure/st_pressure_buffer.c b/drivers/iio/pressure/st_pressure_buffer.c
> index f21b630abaa0..54823cfcfab5 100644
> --- a/drivers/iio/pressure/st_pressure_buffer.c
> +++ b/drivers/iio/pressure/st_pressure_buffer.c
> @@ -29,53 +29,43 @@ int st_press_trig_set_state(struct iio_trigger *trig, bool state)
> return st_sensors_set_dataready_irq(indio_dev, state);
> }
>
> -static int st_press_buffer_preenable(struct iio_dev *indio_dev)
> -{
> - return st_sensors_set_enable(indio_dev, true);
> -}
> -
> static int st_press_buffer_postenable(struct iio_dev *indio_dev)
> {
> - int err;
> struct st_sensor_data *press_data = iio_priv(indio_dev);
> + int err;
>
> press_data->buffer_data = kmalloc(indio_dev->scan_bytes,
> GFP_DMA | GFP_KERNEL);
> - if (press_data->buffer_data == NULL) {
> - err = -ENOMEM;
> - goto allocate_memory_error;
> - }
> + if (!press_data->buffer_data)
> + return -ENOMEM;
>
> err = iio_triggered_buffer_postenable(indio_dev);
> if (err < 0)
> - goto st_press_buffer_postenable_error;
> + goto st_press_free_buffer;
>
> - return err;
> + return st_sensors_set_enable(indio_dev, true);
>
> -st_press_buffer_postenable_error:
> +st_press_free_buffer:
> kfree(press_data->buffer_data);
> -allocate_memory_error:
> return err;
> }
>
> static int st_press_buffer_predisable(struct iio_dev *indio_dev)
> {
> - int err;
> struct st_sensor_data *press_data = iio_priv(indio_dev);
> -
> - err = iio_triggered_buffer_predisable(indio_dev);
> - if (err < 0)
> - goto st_press_buffer_predisable_error;
> + int err, err2;
>
> err = st_sensors_set_enable(indio_dev, false);
>
> -st_press_buffer_predisable_error:
> + err2 = iio_triggered_buffer_predisable(indio_dev);
> + if (!err)
> + err = err2;
> +
> kfree(press_data->buffer_data);
> return err;
> }
>
> static const struct iio_buffer_setup_ops st_press_buffer_setup_ops = {
> - .preenable = &st_press_buffer_preenable,
> .postenable = &st_press_buffer_postenable,
> .predisable = &st_press_buffer_predisable,
> };
next prev parent reply other threads:[~2019-07-30 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 0:03 [PATCH 0/4] preenable/postenable/predisable fixup for ST drivers Denis Ciocca
2019-07-30 0:03 ` [PATCH 1/4] iio:accel: preenable/postenable/predisable fixup for ST accel buffer Denis Ciocca
2019-07-30 8:52 ` Ardelean, Alexandru
2019-07-30 0:03 ` [PATCH 2/4] iio:gyro: preenable/postenable/predisable fixup for ST gyro buffer Denis Ciocca
2019-07-30 8:52 ` Ardelean, Alexandru
2019-07-30 0:03 ` [PATCH 3/4] iio:magn: preenable/postenable/predisable fixup for ST magn buffer Denis Ciocca
2019-07-30 8:54 ` Ardelean, Alexandru
2019-07-30 0:03 ` [PATCH 4/4] iio:pressure: preenable/postenable/predisable fixup for ST press buffer Denis Ciocca
2019-07-30 9:02 ` Ardelean, Alexandru [this message]
2019-07-30 16:08 ` Denis CIOCCA
2019-07-31 6:58 ` Ardelean, Alexandru
2019-07-31 21:48 ` Denis CIOCCA
2019-07-30 9:03 ` [PATCH 0/4] preenable/postenable/predisable fixup for ST drivers Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c73657b4203d8112636751413c85f525f57dcc2a.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).