From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <vilhelm.gray@gmail.com>, <alexandre.torgue@st.com>,
<mcoquelin.stm32@gmail.com>, <benjamin.gaignard@st.com>,
<linux-iio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] counter: stm32-timer-cnt: add power management support
Date: Mon, 10 Feb 2020 18:13:50 +0100 [thread overview]
Message-ID: <dac6eb51-f13c-5369-d43e-77f21ed81172@st.com> (raw)
In-Reply-To: <20200208153541.448a0df3@archlinux>
On 2/8/20 4:35 PM, Jonathan Cameron wrote:
> On Wed, 5 Feb 2020 11:47:58 +0100
> Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
>
>> Add suspend/resume PM sleep ops. When going to low power, enforce the
>> counter isn't active.
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>> ---
>> drivers/counter/stm32-timer-cnt.c | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
>> index 3eafcce..3b84503 100644
>> --- a/drivers/counter/stm32-timer-cnt.c
>> +++ b/drivers/counter/stm32-timer-cnt.c
>> @@ -12,6 +12,7 @@
>> #include <linux/iio/types.h>
>> #include <linux/mfd/stm32-timers.h>
>> #include <linux/module.h>
>> +#include <linux/pinctrl/consumer.h>
>> #include <linux/platform_device.h>
>>
>> #define TIM_CCMR_CCXS (BIT(8) | BIT(0))
>> @@ -358,10 +359,33 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev)
>> priv->counter.num_signals = ARRAY_SIZE(stm32_signals);
>> priv->counter.priv = priv;
>>
>> + platform_set_drvdata(pdev, priv);
>> +
>> /* Register Counter device */
>> return devm_counter_register(dev, &priv->counter);
>> }
>>
>> +static int __maybe_unused stm32_timer_cnt_suspend(struct device *dev)
>> +{
>> + struct stm32_timer_cnt *priv = dev_get_drvdata(dev);
>> + u32 cr1;
>> +
>> + /* Check for active counter */
>> + regmap_read(priv->regmap, TIM_CR1, &cr1);
>> + if (cr1 & TIM_CR1_CEN)
>> + return -EBUSY;
>
> Runtime suspend is allowed to refuse to happen (and that is
> explicitly documented)
> Is that allowed for normal suspend? I didn't think it was.
> This will stop a suspend, but it's doing it by signalling a failure.
Hi Jonathan,
I'll rework this patch, to avoid stopping the suspend. Another approach
is to properly save/backup the registers here, and to disable the
counter in low power mode.
I'll update this in V2.
Thanks for reviewing,
Fabrice
> I'm not sure for example that the system will resume everything that
> was suspended before this call.
>
> Normally you are in the tough luck category if a system decides
> to suspend underneath you. There are ways to prevent it
> from userspace (wakelocks etc).
>
>> +
>> + return pinctrl_pm_select_sleep_state(dev);
>> +}
>> +
>> +static int __maybe_unused stm32_timer_cnt_resume(struct device *dev)
>> +{
>> + return pinctrl_pm_select_default_state(dev);
>> +}
>> +
>> +static SIMPLE_DEV_PM_OPS(stm32_timer_cnt_pm_ops, stm32_timer_cnt_suspend,
>> + stm32_timer_cnt_resume);
>> +
>> static const struct of_device_id stm32_timer_cnt_of_match[] = {
>> { .compatible = "st,stm32-timer-counter", },
>> {},
>> @@ -373,6 +397,7 @@ static struct platform_driver stm32_timer_cnt_driver = {
>> .driver = {
>> .name = "stm32-timer-counter",
>> .of_match_table = stm32_timer_cnt_of_match,
>> + .pm = &stm32_timer_cnt_pm_ops,
>> },
>> };
>> module_platform_driver(stm32_timer_cnt_driver);
>
prev parent reply other threads:[~2020-02-10 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 10:47 [PATCH] counter: stm32-timer-cnt: add power management support Fabrice Gasnier
2020-02-05 17:59 ` William Breathitt Gray
2020-02-08 15:35 ` Jonathan Cameron
2020-02-10 17:13 ` Fabrice Gasnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac6eb51-f13c-5369-d43e-77f21ed81172@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).