linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Gwendal Grignou <gwendal@chromium.org>,
	jic23@kernel.org, bleung@chromium.org
Cc: lars@metafoo.de, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: cros_ec: Set Gyroscope default frequency to 25Hz
Date: Fri, 31 Jul 2020 13:17:53 +0200	[thread overview]
Message-ID: <e98794b4-3f70-ce27-dd64-6bfaff433b8d@collabora.com> (raw)
In-Reply-To: <20200728204825.3312921-1-gwendal@chromium.org>

Hi Gwendal,

Thank you for your patch.

On 28/7/20 22:48, Gwendal Grignou wrote:
> BMI160 Minimium gyroscope frequency in normal mode is 25Hz.
> When older EC firmware do not report their sensors frequencies,
> use 25Hz as the minimum for gyroscope to be sure it works on BMI160.
> 
> Fixes: ae7b02ad2f32d ("iio: common: cros_ec_sensors: Expose cros_ec_sensors
> frequency range via iio sysfs")
> 

I think your email broke this line, it should be a single line. Other than that ...

> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
> Change since v1: Fix spelling.
> 
>  drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> index 156848d27c473..213837c2ecee2 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> @@ -85,10 +85,13 @@ static void get_default_min_max_freq(enum motionsensor_type type,
>  
>  	switch (type) {
>  	case MOTIONSENSE_TYPE_ACCEL:
> -	case MOTIONSENSE_TYPE_GYRO:
>  		*min_freq = 12500;
>  		*max_freq = 100000;
>  		break;
> +	case MOTIONSENSE_TYPE_GYRO:
> +		*min_freq = 25000;
> +		*max_freq = 100000;
> +		break;
>  	case MOTIONSENSE_TYPE_MAG:
>  		*min_freq = 5000;
>  		*max_freq = 25000;
> 

  reply	other threads:[~2020-07-31 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 20:48 [PATCH v2] iio: cros_ec: Set Gyroscope default frequency to 25Hz Gwendal Grignou
2020-07-31 11:17 ` Enric Balletbo i Serra [this message]
2020-08-01 15:46   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98794b4-3f70-ce27-dd64-6bfaff433b8d@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).