From: Rui Miguel Silva <rui.silva@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-iio@vger.kernel.org,
"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/5] iio: gyro: add DT bindings to fxas2100x
Date: Tue, 05 Feb 2019 10:49:22 +0000 [thread overview]
Message-ID: <m31s4m4ij1.fsf@linaro.org> (raw)
In-Reply-To: <CAOMZO5A80yZmE36s1QFX=8uuZ4ctdTVSUoJYUj49t2HcbOKCjQ@mail.gmail.com>
Oi Fabio,
Thanks for the review.
On Mon 04 Feb 2019 at 18:16, Fabio Estevam wrote:
> Hi Rui,
>
> On Mon, Feb 4, 2019 at 3:25 PM Rui Miguel Silva
> <rui.silva@linaro.org> wrote:
>>
>> Add device tree bindings for the FXAS2100x gyroscope.
>
> Please name it after the real part number: FXAS21002.
Yeah, right now it supports the FXAS21002 but if someone wants to
support for example the FXAS21000 it will be easier and the naming
just there, the main differences are ranges. But as we here are
starting with the FXAS210002, I tend to agree.
>
>>
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>> .../bindings/iio/gyroscope/fxas2100x.txt | 14
>> ++++++++++++++
>> 1 file changed, 14 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt
>> b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt
>> new file mode 100644
>> index 000000000000..2aeef9aafec4
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt
>> @@ -0,0 +1,14 @@
>> +* NXP FXAS2100X Gyroscope device tree bindings
>> +
>> +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C
>> +
>> +Required properties:
>> + - compatible : should be "nxp,fxas2100x"
>
> We usually don't put x in the end. Better put the real part
> number
> instead: "nxp,fxas21002"
Yeah, agree.
>
>
>> + - reg : the I2C address of the sensor
>
> Please describe the VDD and VDDIO regulators as well in the
> dt-bindings and also add support for enabling them in the
> driver.
Will do.
---
Cheers,
Rui
next prev parent reply other threads:[~2019-02-05 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 17:00 [PATCH 0/5] iio: gyro: add fxas2100x driver Rui Miguel Silva
2019-02-04 17:00 ` [PATCH 1/5] iio: gyro: add DT bindings to fxas2100x Rui Miguel Silva
2019-02-04 18:16 ` Fabio Estevam
2019-02-05 10:49 ` Rui Miguel Silva [this message]
2019-02-25 21:29 ` Rob Herring
2019-02-04 17:00 ` [PATCH 2/5] iio: gyro: fxas2100x: add core driver for fxas2100x gyroscope Rui Miguel Silva
2019-02-04 20:03 ` Peter Meerwald-Stadler
2019-02-05 10:51 ` Rui Miguel Silva
2019-02-04 17:00 ` [PATCH 3/5] iio: gyro: fxas2100x: add i2c driver Rui Miguel Silva
2019-02-04 17:00 ` [PATCH 4/5] iio: gyro: fxas2100x: add spi driver Rui Miguel Silva
2019-02-04 17:00 ` [PATCH 5/5] ARM: dts: imx7s-warp: add fxas2100x gyroscope Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31s4m4ij1.fsf@linaro.org \
--to=rui.silva@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).