* [PATCH] HID: use multi input quirk for TouchPack touchscreen
@ 2010-02-04 15:36 Thadeu Lima de Souza Cascardo
2010-02-04 17:46 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-04 15:36 UTC (permalink / raw)
To: don
Cc: Thadeu Lima de Souza Cascardo, Jiri Kosina, linux-input,
linux-kernel, linux-usb
This device generates ABS_Z and ABS_RX events, while it should be
generating ABS_X and ABS_Y instead. Using the MULTI_INPUT quirk solves
this issue.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Daniel Oliveira Nascimento <don@syst.com.br>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/usbhid/hid-quirks.c | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index e99485f..ba39103 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -398,6 +398,9 @@
#define USB_VENDOR_ID_THRUSTMASTER 0x044f
+#define USB_VENDOR_ID_TOUCHPACK 0x1bfd
+#define USB_DEVIDE_ID_TOUCHPAK_RTS 0x1688
+
#define USB_VENDOR_ID_TOPMAX 0x0663
#define USB_DEVICE_ID_TOPMAX_COBRAPAD 0x0103
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index edc598d..b89717d 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -45,6 +45,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_ETURBOTOUCH, USB_DEVICE_ID_ETURBOTOUCH, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_PANTHERLORD, USB_DEVICE_ID_PANTHERLORD_TWIN_USB_JOYSTICK, HID_QUIRK_MULTI_INPUT | HID_QUIRK_SKIP_OUTPUT_REPORTS },
{ USB_VENDOR_ID_PLAYDOTCOM, USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII, HID_QUIRK_MULTI_INPUT },
+ { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: use multi input quirk for TouchPack touchscreen
2010-02-04 15:36 [PATCH] HID: use multi input quirk for TouchPack touchscreen Thadeu Lima de Souza Cascardo
@ 2010-02-04 17:46 ` Jiri Kosina
2010-02-04 17:53 ` Thadeu Lima de Souza Cascardo
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2010-02-04 17:46 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo; +Cc: don, linux-input, linux-kernel, linux-usb
On Thu, 4 Feb 2010, Thadeu Lima de Souza Cascardo wrote:
> This device generates ABS_Z and ABS_RX events, while it should be
> generating ABS_X and ABS_Y instead. Using the MULTI_INPUT quirk solves
> this issue.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> Signed-off-by: Daniel Oliveira Nascimento <don@syst.com.br>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index e99485f..ba39103 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -398,6 +398,9 @@
>
> #define USB_VENDOR_ID_THRUSTMASTER 0x044f
>
> +#define USB_VENDOR_ID_TOUCHPACK 0x1bfd
> +#define USB_DEVIDE_ID_TOUCHPAK_RTS 0x1688
> +
Umm .. there are two typos in this single line. Please compile-test your
patches before submitting them.
I have fixed it and applied, thanks.
> #define USB_VENDOR_ID_TOPMAX 0x0663
> #define USB_DEVICE_ID_TOPMAX_COBRAPAD 0x0103
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index edc598d..b89717d 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -45,6 +45,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_ETURBOTOUCH, USB_DEVICE_ID_ETURBOTOUCH, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_PANTHERLORD, USB_DEVICE_ID_PANTHERLORD_TWIN_USB_JOYSTICK, HID_QUIRK_MULTI_INPUT | HID_QUIRK_SKIP_OUTPUT_REPORTS },
> { USB_VENDOR_ID_PLAYDOTCOM, USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
> --
> 1.6.6.1
>
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: use multi input quirk for TouchPack touchscreen
2010-02-04 17:46 ` Jiri Kosina
@ 2010-02-04 17:53 ` Thadeu Lima de Souza Cascardo
0 siblings, 0 replies; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2010-02-04 17:53 UTC (permalink / raw)
To: Jiri Kosina; +Cc: don, linux-input, linux-kernel, linux-usb
[-- Attachment #1: Type: text/plain, Size: 2429 bytes --]
On Thu, Feb 04, 2010 at 06:46:26PM +0100, Jiri Kosina wrote:
> On Thu, 4 Feb 2010, Thadeu Lima de Souza Cascardo wrote:
>
> > This device generates ABS_Z and ABS_RX events, while it should be
> > generating ABS_X and ABS_Y instead. Using the MULTI_INPUT quirk solves
> > this issue.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> > Signed-off-by: Daniel Oliveira Nascimento <don@syst.com.br>
> > ---
> > drivers/hid/hid-ids.h | 3 +++
> > drivers/hid/usbhid/hid-quirks.c | 1 +
> > 2 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index e99485f..ba39103 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -398,6 +398,9 @@
> >
> > #define USB_VENDOR_ID_THRUSTMASTER 0x044f
> >
> > +#define USB_VENDOR_ID_TOUCHPACK 0x1bfd
> > +#define USB_DEVIDE_ID_TOUCHPAK_RTS 0x1688
> > +
>
> Umm .. there are two typos in this single line. Please compile-test your
> patches before submitting them.
>
> I have fixed it and applied, thanks.
>
Heh! Daniel has pointed this out to me too. I'm pretty sure I've
finished this build, but something must have happened. Perhaps, this was
when my computer has turned off because of bad wiring and I forgot
completely that this was building.
I am sorry for this. And thanks for the fix.
> > #define USB_VENDOR_ID_TOPMAX 0x0663
> > #define USB_DEVICE_ID_TOPMAX_COBRAPAD 0x0103
> >
> > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> > index edc598d..b89717d 100644
> > --- a/drivers/hid/usbhid/hid-quirks.c
> > +++ b/drivers/hid/usbhid/hid-quirks.c
> > @@ -45,6 +45,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_ETURBOTOUCH, USB_DEVICE_ID_ETURBOTOUCH, HID_QUIRK_MULTI_INPUT },
> > { USB_VENDOR_ID_PANTHERLORD, USB_DEVICE_ID_PANTHERLORD_TWIN_USB_JOYSTICK, HID_QUIRK_MULTI_INPUT | HID_QUIRK_SKIP_OUTPUT_REPORTS },
> > { USB_VENDOR_ID_PLAYDOTCOM, USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII, HID_QUIRK_MULTI_INPUT },
> > + { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
> >
> > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
> > { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
> > --
> > 1.6.6.1
> >
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-04 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-04 15:36 [PATCH] HID: use multi input quirk for TouchPack touchscreen Thadeu Lima de Souza Cascardo
2010-02-04 17:46 ` Jiri Kosina
2010-02-04 17:53 ` Thadeu Lima de Souza Cascardo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).