linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family
@ 2022-10-06 10:58 Sheng-Liang Pan
  2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
  0 siblings, 1 reply; 4+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
  To: LKML
  Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
	Dmitry Torokhov, Rob Herring, Stephen Boyd, devicetree,
	linux-arm-msm, linux-input

This patch add common dtsi and WIFI/LTE dts for evoker

Changes in v7:
- goodix gt7986 dt bindings added in v7
- add compiatable for gt7986

Changes in v6:
- add removed pinctrl and align touchscreen label with herobrine board

Changes in v5:
- recover whitespace change
- new patch for Touchscreen/trackpad in v5

Changes in v4:
- fix typo in tittle and commit
- recover change for trackpad and touchscreen

Changes in v3:
- none

Changes in v2:
- none

Sheng-Liang Pan (4):
  dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker
  arm64: dts: qcom: Add LTE SKU for sc7280-evoker family
  dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
  arm64: dts: qcom: Add touchscreen and touchpad support for evoker

 .../devicetree/bindings/arm/qcom.yaml         |  5 +++++
 .../bindings/input/goodix,gt7375p.yaml        |  5 ++++-
 arch/arm64/boot/dts/qcom/Makefile             |  3 ++-
 .../dts/qcom/sc7280-herobrine-evoker-lte.dts  | 14 ++++++++++++
 .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++
 ...er-r0.dts => sc7280-herobrine-evoker.dtsi} | 22 ++++++-------------
 6 files changed, 47 insertions(+), 17 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
 rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (95%)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
  2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-06 10:58 ` Sheng-Liang Pan
  2022-10-06 19:53   ` Doug Anderson
  2022-10-06 20:08   ` Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Sheng-Liang Pan @ 2022-10-06 10:58 UTC (permalink / raw)
  To: LKML
  Cc: dianders, Sheng-Liang Pan, Dmitry Torokhov, Rob Herring,
	devicetree, linux-input

Add an goodix touch screen chip GT7986U.

Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---

Changes in v7:
- goodix gt7986 dt bindings added in v7

 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
index fe1c5016f7f31..1c191bc5a1782 100644
--- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
+++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
@@ -16,8 +16,11 @@ description:
 
 properties:
   compatible:
-    items:
+    oneOf:
       - const: goodix,gt7375p
+      - items:
+          - const: goodix,gt7986u
+          - const: goodix,gt7375p
 
   reg:
     enum:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
  2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
@ 2022-10-06 19:53   ` Doug Anderson
  2022-10-06 20:08   ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2022-10-06 19:53 UTC (permalink / raw)
  To: Sheng-Liang Pan
  Cc: LKML, Dmitry Torokhov, Rob Herring, devicetree, linux-input

Hi,

On Thu, Oct 6, 2022 at 3:58 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Add an goodix touch screen chip GT7986U.

In theory you could beef up the commit message explaining that GT7986U
is expected to be fully compatible with a driver written for GT7375P,
but I wouldn't spin just for that.


> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v7:
> - goodix gt7986 dt bindings added in v7
>
>  Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> index fe1c5016f7f31..1c191bc5a1782 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -16,8 +16,11 @@ description:
>
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - const: goodix,gt7375p
> +      - items:
> +          - const: goodix,gt7986u
> +          - const: goodix,gt7375p

I haven't run this through schema validation, but from a visual
inspection it looks good to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
  2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
  2022-10-06 19:53   ` Doug Anderson
@ 2022-10-06 20:08   ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-10-06 20:08 UTC (permalink / raw)
  To: Sheng-Liang Pan
  Cc: Dmitry Torokhov, dianders, linux-input, devicetree, LKML, Rob Herring

On Thu, 06 Oct 2022 18:58:22 +0800, Sheng-Liang Pan wrote:
> Add an goodix touch screen chip GT7986U.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
> 
> Changes in v7:
> - goodix gt7986 dt bindings added in v7
> 
>  Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-10-06 20:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
2022-10-06 19:53   ` Doug Anderson
2022-10-06 20:08   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).