Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: "Petr Štetiar" <ynezz@true.cz>
To: Stephane Chatty <chatty@lii-enac.fr>
Cc: linux-input@vger.kernel.org, dsuljic@mmm.com
Subject: Re: [PATCH] Support for 3M multitouch panel
Date: Fri, 11 Dec 2009 13:42:26 +0100
Message-ID: <20091211124226.GD17995@ibawizard.net> (raw)
In-Reply-To: <20091211101258.CD35D951F5@smtp.lii-enac.fr>

Stephane Chatty <chatty@lii-enac.fr> [2009-12-11 11:12:58]:

> Added support for 3M multitouch panel.

Hi,

you maybe forget to run checkpatch on it :-)

WARNING: space prohibited between function name and open parenthesis '('
#131: FILE: drivers/hid/hid-3m-pct.c:122:
+static void mmm_filter_event (struct mmm_data *md, struct input_dev *input)

WARNING: space prohibited between function name and open parenthesis '('
#195: FILE: drivers/hid/hid-3m-pct.c:186:
+static int mmm_event (struct hid_device *hid, struct hid_field *field,

ERROR: code indent should use tabs where possible
#196: FILE: drivers/hid/hid-3m-pct.c:187:
+^I^I                        struct hid_usage *usage, __s32 value)$

ERROR: code indent should use tabs where possible
#199: FILE: drivers/hid/hid-3m-pct.c:190:
+        /* Strangely, this function can be called before$

ERROR: code indent should use tabs where possible
#202: FILE: drivers/hid/hid-3m-pct.c:193:
+        if (hid->claimed & HID_CLAIMED_INPUT) {$

WARNING: space prohibited between function name and open parenthesis '('
#227: FILE: drivers/hid/hid-3m-pct.c:218:
+                       mmm_filter_event (md, input);

ERROR: code indent should use tabs where possible
#233: FILE: drivers/hid/hid-3m-pct.c:224:
+        if (hid->claimed & HID_CLAIMED_HIDDEV && hid->hiddev_hid_event)$

ERROR: code indent should use tabs where possible
#234: FILE: drivers/hid/hid-3m-pct.c:225:
+                hid->hiddev_hid_event(hid, field, usage, value);$

WARNING: space prohibited between function name and open parenthesis '('
#256: FILE: drivers/hid/hid-3m-pct.c:247:
+               kfree (md);

total: 5 errors, 4 warnings, 328 lines checked 

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 10:12 Stephane Chatty
2009-12-11 12:42 ` Petr Štetiar [this message]
2009-12-11 14:10   ` Fwd: " Stephane Chatty
2009-12-11 22:36     ` Dmitry Torokhov
2009-12-12  8:13       ` Stéphane Chatty
2009-12-12  8:30         ` Dmitry Torokhov
2009-12-22 18:00       ` Stéphane Chatty
2009-12-22 18:56         ` Dmitry Torokhov
2009-12-22 19:27           ` Stéphane Chatty
2009-12-22 22:04           ` Stephane Chatty
2009-12-23  0:22             ` Jiri Kosina
2009-12-23  0:33             ` Jiri Kosina
2009-12-23  9:47               ` Stéphane Chatty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211124226.GD17995@ibawizard.net \
    --to=ynezz@true.cz \
    --cc=chatty@lii-enac.fr \
    --cc=dsuljic@mmm.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git