linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Stephane Chatty <chatty@lii-enac.fr>
Cc: dmitry.torokhov@gmail.com, chatty@enac.fr, ynezz@true.cz,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] Support for 3M multitouch panel
Date: Wed, 23 Dec 2009 01:33:03 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.0912230131530.3755@pobox.suse.cz> (raw)
In-Reply-To: <20091222220417.EA008951F2@smtp.lii-enac.fr>

On Tue, 22 Dec 2009, Stephane Chatty wrote:

> Added support for 3M multitouch panels.

... I had to fix trivial build failure (3M vs. MMM inconsistency in 
defines).

> +config HID_3M_PCT
> +	tristate "3M PCT" if EMBEDDED
> +	depends on USB_HID
> +	default !EMBEDDED

Hmm, I wouldn't be so sure about this in this case ... the point behind 
'default !EMBEDDED' was that simple a straightforward quirks for HID 
devices (which are implemented as drivers on HID bus) wouldn't have to be 
enabled separately, if the device is otherwise more-or-less HID standard 
compliant.

But this driver is rather standalone driver, I guess we'd want to have it 
normally selectable.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

  parent reply	other threads:[~2009-12-23  0:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 10:12 [PATCH] Support for 3M multitouch panel Stephane Chatty
2009-12-11 12:42 ` Petr Štetiar
2009-12-11 14:10   ` Fwd: " Stephane Chatty
2009-12-11 22:36     ` Dmitry Torokhov
2009-12-12  8:13       ` Stéphane Chatty
2009-12-12  8:30         ` Dmitry Torokhov
2009-12-22 18:00       ` Stéphane Chatty
2009-12-22 18:56         ` Dmitry Torokhov
2009-12-22 19:27           ` Stéphane Chatty
2009-12-22 22:04           ` Stephane Chatty
2009-12-23  0:22             ` Jiri Kosina
2009-12-23  0:33             ` Jiri Kosina [this message]
2009-12-23  9:47               ` Stéphane Chatty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.0912230131530.3755@pobox.suse.cz \
    --to=jkosina@suse.cz \
    --cc=chatty@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).