linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, rvinyard@cs.nmsu.edu, dtor@mail.ru,
	oliver@neukum.org
Subject: Re: [patch 1/1] hid: Logitech G13 driver 0.0.2
Date: Tue, 22 Dec 2009 16:03:07 -0800	[thread overview]
Message-ID: <20091222160307.0018bda9.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.0912230056120.3755@pobox.suse.cz>

On Wed, 23 Dec 2009 00:57:43 +0100 (CET)
Jiri Kosina <jkosina@suse.cz> wrote:

> On Mon, 21 Dec 2009, akpm@linux-foundation.org wrote:
> 
> > From: "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>
> > 
> > This is a driver for the Logitech G13 gamepad, and contains three key
> > parts.  In the USB reports the device identifies itself as a HID, and as a
> > result this driver is under the HID framework.
> > 
> > There are two primary sub-components to this driver; an input device and a
> > framebuffer device.
> > 
> > Although identified as a HID, the device does not support standard HID
> > input messages.  As a result, a sub-input device is allocated and
> > registered separately in g13_probe().  The raw events are monitored and
> > key presses/joystick activity is reported through the input device after
> > referencing an indexed keymap.
> > 
> > Additionally, this device contains a 160x43 monochrome LCD display.  A
> > registered framebuffer device manages this display.  The design of this
> > portion of the driver was based on the design of the hecubafb driver with
> > deferred framebuffer I/O since there is no real memory to map.
> > 
> > Signed-off-by: Rick L. Vinyard, Jr <rvinyard@cs.nmsu.edu>
> > Cc: Oliver Neukum <oliver@neukum.org>
> > Cc: Dmitry Torokhov <dtor@mail.ru>
> > Cc: Jiri Kosina <jkosina@suse.cz>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> The driver doesn't build for me. Seems like missing some 
> framebuffer-related include at a first glance.
> 
> Rick, care to fix that up please?
> 
> drivers/hid/hid-g13.c:121: error: field ___fb_defio___ has incomplete type
> drivers/hid/hid-g13.c:1207: error: variable ___g13_fb_defio___ has initializerbut incomplete type
> drivers/hid/hid-g13.c:1208: error: unknown field ___delay___ specified ininitializer
> drivers/hid/hid-g13.c:1208: warning: excess elements in struct initializer
> drivers/hid/hid-g13.c:1208: warning: (near initialization for ___g13_fb_defio___)
> drivers/hid/hid-g13.c:1209: error: unknown field ___deferred_io___ specified in initializer
> drivers/hid/hid-g13.c:1209: warning: excess elements in struct initializer
> drivers/hid/hid-g13.c:1209: warning: (near initialization for ___g13_fb_defio___)
> drivers/hid/hid-g13.c: In function ___g13_probe___:drivers/hid/hid-g13.c:1351: error: ___struct fb_info___ has no member named ___fbdefio___
> 

Missing CONFIG_FB_DEFERRED_IO, I assume?

--- a/drivers/hid/Kconfig~hid-logitech-g13-driver-002-fix
+++ a/drivers/hid/Kconfig
@@ -187,6 +187,7 @@ config LOGITECH_G13
 	tristate "Logitech G13 gameboard support"
 	depends on HID_LOGITECH
 	depends on FB
+	depends on FB_DEFERRED_IO
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
_


  reply	other threads:[~2009-12-23  0:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22  0:22 [patch 1/1] hid: Logitech G13 driver 0.0.2 akpm
2009-12-22 23:57 ` Jiri Kosina
2009-12-23  0:03   ` Andrew Morton [this message]
2009-12-23  0:16     ` Jiri Kosina
2010-01-06 16:23       ` Rick L. Vinyard, Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091222160307.0018bda9.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dtor@mail.ru \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=rvinyard@cs.nmsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).