From: "Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-input@vger.kernel.org, dtor@mail.ru, oliver@neukum.org
Subject: Re: [patch 1/1] hid: Logitech G13 driver 0.0.2
Date: Wed, 6 Jan 2010 09:23:25 -0700 [thread overview]
Message-ID: <e4857e132859fc5a73c584f1593587ba.squirrel@intranet.cs.nmsu.edu> (raw)
In-Reply-To: <alpine.LNX.2.00.0912230111010.3755@pobox.suse.cz>
Jiri Kosina wrote:
> Still, this is not the only build problem of this driver. Apparently it
> also doesn't like to be built as module (together with all the
> HID_LOGITECH stuff).
>
> drivers/hid/hid-g13.o:(.rodata+0x1e0): multiple definition of
> `__mod_hid_device_table'
> drivers/hid/hid-lg.o:(.rodata+0x540): first defined here
> ld: Warning: size of symbol `__mod_hid_device_table' changed from 552 in
> drivers/hid/hid-lg.o to 48 in drivers/hid/hid-g13.o
> drivers/hid/hid-g13.o: In function `g13_init':
> /home/jkosina/src/hid/drivers/hid/hid-g13.c:1513: multiple definition of
> `init_module'
> drivers/hid/hid-lg.o:/home/jkosina/src/hid/drivers/hid/hid-lg.c:354: first
> defined here
> drivers/hid/hid-g13.o: In function `g13_exit':
> /home/jkosina/src/hid/drivers/hid/hid-g13.c:1518: multiple definition of
> `cleanup_module'
> drivers/hid/hid-lg.o:/home/jkosina/src/hid/drivers/hid/hid-lg.c:359: first
> defined here
> make[1]: *** [drivers/hid/hid-logitech.o] Error 1
>
Even though the G13 is a Logitech device, perhaps I should break it out of
the Logitech stuff. In reality, the "Logitech" option is a bit of a
misnomer. It doesn't appear to be Logitech in general but rather Logitech
Force Feedback devices.
There's nothing in the driver that needs the Logitech force feedback code.
---
Rick
prev parent reply other threads:[~2010-01-06 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 0:22 [patch 1/1] hid: Logitech G13 driver 0.0.2 akpm
2009-12-22 23:57 ` Jiri Kosina
2009-12-23 0:03 ` Andrew Morton
2009-12-23 0:16 ` Jiri Kosina
2010-01-06 16:23 ` Rick L. Vinyard, Jr. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4857e132859fc5a73c584f1593587ba.squirrel@intranet.cs.nmsu.edu \
--to=rvinyard@cs.nmsu.edu \
--cc=akpm@linux-foundation.org \
--cc=dtor@mail.ru \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).