From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: Adam Ford <aford173@gmail.com>,
Sven Van Asbroeck <thesven73@gmail.com>,
linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Input: ili210x - add ILI2117 support
Date: Sun, 3 Nov 2019 23:02:09 -0800 [thread overview]
Message-ID: <20191104070209.GN57214@dtor-ws> (raw)
In-Reply-To: <af0b175c-ced0-1a01-9a19-7e49fdb3386d@denx.de>
On Mon, Nov 04, 2019 at 01:16:21AM +0100, Marek Vasut wrote:
> On 11/4/19 12:55 AM, Adam Ford wrote:
> > On Fri, Nov 1, 2019 at 3:48 PM Sven Van Asbroeck wrote:
> >>
> >> Dmitry / Marek,
> >>
> >> There have been two attempts to add ILI2117 touch controller support.
> >> I was about to add a third, but luckily I checked the mailing list
> >> before writing any code :)
> >>
> >> Adding this support would clearly be beneficial for the common good.
> >> What can we do to get this in motion again?
> >>
> >> Last time I checked, Marek posted a patch which added the 2117, but Dmitry
> >> objected, because the code became too unwieldy. Dmitry then posted a cleanup
> >> patch, which did not work for Marek. So everything came to a halt.
> >> See:
> >> https://patchwork.kernel.org/patch/10836651/
> >> https://www.spinics.net/lists/linux-input/msg62670.html
> >>
> >> Dmitry, would you perhaps be willing to accept Marek's patch, and perform the
> >> cleanup later?
> >>
> >> Marek, would you perhaps be willing to invest some time to debug Dmitry's
> >> cleanup patch?
> >>
> >> On my end, I've reviewed Dmitry's patch and it looks mostly ok. I saw one
> >> difference with ILI210X which could explain Marek's results, but I can't be
> >> sure - because I could not locate the 210X's register layout on the web.
> >>
> >> In Dmitry's patch, we see:
> >>
> >> touch = ili210x_report_events(priv, touchdata);
> >> if (touch || chip->continue_polling(touchdata))
> >> schedule_delayed_work(&priv->dwork,
> >> msecs_to_jiffies(priv->poll_period));
> >>
> >> but this is not exactly equivalent to the original. Because in the original,
> >> the 210X's decision to kick off delayed work is completely independent of
> >> the value of touch.
> >>
> >
> > If anyone is interested, I posted a patch to add ili2117A.
> > https://patchwork.kernel.org/patch/10849877/
> >
> > I am not sure if it's compatible with the non-A version.
>
> This patch could've gone in as-is, the rework was not necessary (and
> indeed, didn't work). I don't know why this patch wasn't applied in the
> end, maybe it was just missed.
Do we really need a brand new driver here? It looks pretty similar to
the other flavors...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-11-04 7:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190302141704.32547-1-marex@denx.de>
2019-11-01 20:48 ` [PATCH 2/2] Input: ili210x - add ILI2117 support Sven Van Asbroeck
2019-11-03 23:55 ` Adam Ford
2019-11-04 0:16 ` Marek Vasut
2019-11-04 7:02 ` Dmitry Torokhov [this message]
2019-11-04 7:01 ` Dmitry Torokhov
2019-11-04 9:13 ` Marek Vasut
2019-11-04 13:49 ` Sven Van Asbroeck
2019-11-04 14:19 ` Adam Ford
2019-11-04 18:36 ` Dmitry Torokhov
2019-11-04 18:37 ` Sven Van Asbroeck
2019-11-04 21:28 ` Adam Ford
2019-11-04 21:43 ` Sven Van Asbroeck
2019-11-04 23:25 ` Adam Ford
2019-11-04 23:36 ` Dmitry Torokhov
2019-11-04 23:40 ` Adam Ford
2019-11-05 2:04 ` Sven Van Asbroeck
2019-11-05 13:27 ` Adam Ford
2019-11-05 15:26 ` Sven Van Asbroeck
2019-11-05 15:29 ` Sven Van Asbroeck
2019-11-05 15:53 ` Sven Van Asbroeck
2019-11-11 18:16 ` Dmitry Torokhov
2019-11-11 18:43 ` Rob Herring
2019-11-12 0:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104070209.GN57214@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aford173@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).