From: Marek Vasut <marex@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sven Van Asbroeck <thesven73@gmail.com>
Cc: Adam Ford <aford173@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: ili210x - add ILI2117 support
Date: Mon, 4 Nov 2019 10:13:31 +0100 [thread overview]
Message-ID: <f4390226-055b-3667-e156-78695ae911e5@denx.de> (raw)
In-Reply-To: <20191104070116.GM57214@dtor-ws>
On 11/4/19 8:01 AM, Dmitry Torokhov wrote:
> Hi Sven,
>
> On Fri, Nov 01, 2019 at 04:48:01PM -0400, Sven Van Asbroeck wrote:
>> Dmitry / Marek,
>>
>> There have been two attempts to add ILI2117 touch controller support.
>> I was about to add a third, but luckily I checked the mailing list
>> before writing any code :)
>>
>> Adding this support would clearly be beneficial for the common good.
>> What can we do to get this in motion again?
>>
>> Last time I checked, Marek posted a patch which added the 2117, but Dmitry
>> objected, because the code became too unwieldy. Dmitry then posted a cleanup
>> patch, which did not work for Marek. So everything came to a halt.
>> See:
>> https://patchwork.kernel.org/patch/10836651/
>> https://www.spinics.net/lists/linux-input/msg62670.html
>>
>> Dmitry, would you perhaps be willing to accept Marek's patch, and perform the
>> cleanup later?
>>
>> Marek, would you perhaps be willing to invest some time to debug Dmitry's
>> cleanup patch?
>>
>> On my end, I've reviewed Dmitry's patch and it looks mostly ok. I saw one
>> difference with ILI210X which could explain Marek's results, but I can't be
>> sure - because I could not locate the 210X's register layout on the web.
>>
>> In Dmitry's patch, we see:
>>
>> touch = ili210x_report_events(priv, touchdata);
>> if (touch || chip->continue_polling(touchdata))
>> schedule_delayed_work(&priv->dwork,
>> msecs_to_jiffies(priv->poll_period));
>>
>> but this is not exactly equivalent to the original. Because in the original,
>> the 210X's decision to kick off delayed work is completely independent of
>> the value of touch.
>
> No, it is not independent really. Bits 0 and 1 in the first byte
> correspond to touches with first and 2nd finger, so checking for touch
> in addition to 0xf3 mask is not incorrect.
>
> Can you please tell me what device you have? Do the patches work for
> you?
>
> Marek, sorry for letting the patches linger. Can you please tell me what
> touch controller did you test with that failed for you?
See Message-ID <20190917032842.GL237523@dtor-ws> . I tested the ILI2117
with these two patches and it works. With the additional two patches
from you on top, it failed, unless I reverted:
Input: ili210x - define and use chip operations structure
> I think I see at
> least one issue in ili251x_read_touch_data() - the check whether we
> should read the second part of the packet should check if data[0] == 2,
> not 0.
But that's not a problem of this particular patch, so maybe this patch
can finally be applied and then we can debug the subsequent patches ?
next prev parent reply other threads:[~2019-11-04 9:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190302141704.32547-1-marex@denx.de>
2019-11-01 20:48 ` [PATCH 2/2] Input: ili210x - add ILI2117 support Sven Van Asbroeck
2019-11-03 23:55 ` Adam Ford
2019-11-04 0:16 ` Marek Vasut
2019-11-04 7:02 ` Dmitry Torokhov
2019-11-04 7:01 ` Dmitry Torokhov
2019-11-04 9:13 ` Marek Vasut [this message]
2019-11-04 13:49 ` Sven Van Asbroeck
2019-11-04 14:19 ` Adam Ford
2019-11-04 18:36 ` Dmitry Torokhov
2019-11-04 18:37 ` Sven Van Asbroeck
2019-11-04 21:28 ` Adam Ford
2019-11-04 21:43 ` Sven Van Asbroeck
2019-11-04 23:25 ` Adam Ford
2019-11-04 23:36 ` Dmitry Torokhov
2019-11-04 23:40 ` Adam Ford
2019-11-05 2:04 ` Sven Van Asbroeck
2019-11-05 13:27 ` Adam Ford
2019-11-05 15:26 ` Sven Van Asbroeck
2019-11-05 15:29 ` Sven Van Asbroeck
2019-11-05 15:53 ` Sven Van Asbroeck
2019-11-11 18:16 ` Dmitry Torokhov
2019-11-11 18:43 ` Rob Herring
2019-11-12 0:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4390226-055b-3667-e156-78695ae911e5@denx.de \
--to=marex@denx.de \
--cc=aford173@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).